CompatHelper: bump compat for AMDGPU in [weakdeps] to 2, (keep existing compat)#2478
Closed
github-actions[bot] wants to merge 2 commits intomainfrom
Closed
Conversation
ranocha
force-pushed
the
compathelper/new_version/2025-07-19-00-05-21-094-02699836661
branch
from
eb10d3b to
43223f0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2478 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 507 507
Lines 42010 42010
=======================================
Hits 40610 40610
Misses 1400 1400
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…sting compat) (#2479) Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
ranocha
requested changes
Jul 20, 2025
Member
ranocha
left a comment
ranocha
left a comment
There was a problem hiding this comment.
Requires a compat update in MPI.jl to test the new version
Member
|
The break does directly impact us as well. For now let me unwind the AMDGPU extension since we currently can't test it properly. |
Member
|
This will be handled in #2486 |
ranocha
deleted the
compathelper/new_version/2025-07-19-00-05-21-094-02699836661
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
AMDGPUpackage from1.3.5to1.3.5, 2.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.