WIP: Additional analysis for multi-component Euler systems.#2414
Draft
WIP: Additional analysis for multi-component Euler systems.#2414
Conversation
Contributor
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2414 +/- ##
==========================================
- Coverage 96.36% 87.08% -9.27%
==========================================
Files 527 527
Lines 42559 42629 +70
==========================================
- Hits 41008 37123 -3885
- Misses 1551 5506 +3955
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+291
to
+298
| @inline function enstrophy(u, equations::CompressibleNavierStokesDiffusion2D; gradients) | ||
| # Enstrophy is 0.5 rho ω⋅ω where ω = ∇ × v | ||
|
|
||
| omega = vorticity(u, gradients, equations) | ||
| return 0.5f0 * u[1] * omega^2 | ||
| end | ||
|
|
||
| @inline function vorticity(u, gradients, equations::CompressibleNavierStokesDiffusion2D) | ||
| @inline function vorticity(u, equations::CompressibleNavierStokesDiffusion2D; gradients) |
Member
There was a problem hiding this comment.
Why different signature compared to old and added functions?
src/callbacks_step/analysis_dg2d.jl
Outdated
| u_local = get_node_vars(u, equations, dg, i, j, element) | ||
| return func(u_local, equations) | ||
| end | ||
| @autoinfiltrate |
Member
There was a problem hiding this comment.
What does that do/why is this needed?
src/callbacks_step/analysis_dg2d.jl
Outdated
| return func(u_local, equations) | ||
| end | ||
| @autoinfiltrate | ||
| if length(m.sig.parameters) == 2 |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Attempt of using existing infrastructure for parabolic terms to compute derivatives.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…-framework/Trixi.jl into sc/analysis_multi_euler_2d
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| normalize = normalize) do u, i, j, element, | ||
| equations, dg | ||
| u_local = get_node_vars(u, equations, dg, i, j, element) | ||
| gradients_local = Vector([gradients_x[:, i, j, element], gradients_y[:, i, j, element]]) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| gradients_local = Vector([gradients_x[:, i, j, element], gradients_y[:, i, j, element]]) | |
| gradients_local = Vector([ | |
| gradients_x[:, i, j, element], | |
| gradients_y[:, i, j, element] | |
| ]) |
|
|
||
| # Compute the surface flux terms. | ||
| surface_flux_values = similar(u) | ||
| Trixi.calc_surface_integral!(surface_flux_values, u, mesh, equations, dg.surface_integral, dg, cache) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| Trixi.calc_surface_integral!(surface_flux_values, u, mesh, equations, dg.surface_integral, dg, cache) | |
| Trixi.calc_surface_integral!(surface_flux_values, u, mesh, equations, | |
| dg.surface_integral, dg, cache) |
Comment on lines
+336
to
+338
| # # Contract D in the ξ̂ (first spatial) direction | ||
| # gradients[v, :, :, elem] .= D * u[v, :, :, elem] | ||
| # # Average over element. |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # # Contract D in the ξ̂ (first spatial) direction | |
| # gradients[v, :, :, elem] .= D * u[v, :, :, elem] | |
| # # Average over element. | |
| # # Contract D in the ξ̂ (first spatial) direction | |
| # gradients[v, :, :, elem] .= D * u[v, :, :, elem] | |
| # # Average over element. |
| # gradients[v, :, :, elem] .= D * u[v, :, :, elem] | ||
| # # Average over element. | ||
|
|
||
| average = sum(gradients[v, :, :, elem]/Np^2) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| average = sum(gradients[v, :, :, elem]/Np^2) | |
| average = sum(gradients[v, :, :, elem] / Np^2) |
Comment on lines
+361
to
+362
| # # Contract D in the ξ̂ (first spatial) direction | ||
| # gradients[v, :, :, elem] .= u[v, :, :, elem] * D' |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # # Contract D in the ξ̂ (first spatial) direction | |
| # gradients[v, :, :, elem] .= u[v, :, :, elem] * D' | |
| # # Contract D in the ξ̂ (first spatial) direction | |
| # gradients[v, :, :, elem] .= u[v, :, :, elem] * D' |
| # gradients[v, :, :, elem] .= u[v, :, :, elem] * D' | ||
|
|
||
| # Average over element. | ||
| average = sum(gradients[v, :, :, elem]/Np^2) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| average = sum(gradients[v, :, :, elem]/Np^2) | |
| average = sum(gradients[v, :, :, elem] / Np^2) |
| enstrophy, vorticity | ||
| export entropy, energy_total, energy_kinetic, energy_internal, energy_magnetic, | ||
| cross_helicity, | ||
| enstrophy, magnetic_field, divergence_cleaning_field, enstrophy_multi_euler, vorticity |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| enstrophy, magnetic_field, divergence_cleaning_field, enstrophy_multi_euler, vorticity | |
| enstrophy, magnetic_field, divergence_cleaning_field, enstrophy_multi_euler, | |
| vorticity |
| end | ||
|
|
||
| @inline function enstrophy_multi_euler(u, gradients, | ||
| equations::CompressibleEulerMulticomponentEquations2D) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| equations::CompressibleEulerMulticomponentEquations2D) | |
| equations::CompressibleEulerMulticomponentEquations2D) |
and normal_direction::AbstractVector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds analysis options, like enstrophy for the multicomponent Euler scheme.