Skip to content

Comments

add minimal CUDA pipeline#2367

Closed
vchuravy wants to merge 6 commits intovc/adaptfrom
vc/buildkite
Closed

add minimal CUDA pipeline#2367
vchuravy wants to merge 6 commits intovc/adaptfrom
vc/buildkite

Conversation

@vchuravy
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

vchuravy and others added 3 commits April 21, 2025 21:36
In order to eventually support GPU computation we need
to use Adapt.jl to allow GPU backend packages to swap
out host-array types like `CuArray` with device-side types
like `CuDeviceArray`.

Additionally this will allow us to change the element type
of a simulation by using `adapt(Array{Float32}`.

Co-authored-by: Lars Christmann <account-github@l12n.eu>
Co-authored-by: Benedict Geihe <bgeihe@uni-koeln.de>
@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 70.81081% with 54 lines in your changes missing coverage. Please review.

Project coverage is 96.82%. Comparing base (aad2399) to head (fb3e901).
Report is 6 commits behind head on vc/adapt.

Files with missing lines Patch % Lines
src/solvers/dgsem_p4est/containers_parallel.jl 26.92% 19 Missing ⚠️
src/solvers/dgsem_p4est/containers.jl 82.72% 14 Missing ⚠️
src/auxiliary/containers.jl 67.74% 10 Missing ⚠️
src/auxiliary/vector_of_arrays.jl 35.71% 9 Missing ⚠️
ext/TrixiCUDAExt.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           vc/adapt    #2367      +/-   ##
============================================
- Coverage     96.93%   96.82%   -0.11%     
============================================
  Files           501      503       +2     
  Lines         41598    41749     +151     
============================================
+ Hits          40322    40421      +99     
- Misses         1276     1328      +52     
Flag Coverage Δ
unittests 96.82% <70.81%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vchuravy vchuravy closed this Apr 22, 2025
@vchuravy vchuravy deleted the vc/buildkite branch April 22, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant