Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
506 commits
Select commit Hold shift + click to select a range
abedff4
Merge branch 'sc/p4est-view-coupled' of https://github.com/trixi-fram…
SimonCan Jun 16, 2025
afa88ce
Removed another redundant foreach_enumerate funciton definition.
SimonCan Jun 16, 2025
ecee86a
Removed further redundant definitions.
SimonCan Jun 16, 2025
586ae5d
Removed unused ncells definition.
SimonCan Jun 16, 2025
b550f63
Merge branch 'main' into sc/p4est-view-coupled
DanielDoehring Jun 17, 2025
cfef1b7
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jun 20, 2025
90ff72a
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Jun 23, 2025
e8064ec
Added integer to string conversion for sving mesh files for coupled s…
SimonCan Jun 23, 2025
aa30aa6
Merge branch 'main' into sc/p4est-view-coupled
DanielDoehring Jun 28, 2025
6ba8e6d
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Jun 30, 2025
34181c0
Correcte comment fo rglobal cell id converion funciton when input is …
SimonCan Jun 30, 2025
3bd7911
Error arrays for coupled simulations are now pre-allocated.
SimonCan Jun 30, 2025
b2c69bb
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Jun 30, 2025
21a4291
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Jun 30, 2025
1cda279
Added comment on p4est coupled boundary conditions and that they only…
SimonCan Jun 30, 2025
5af5ebe
Merge branch 'sc/p4est-view-coupled' of https://github.com/trixi-fram…
SimonCan Jun 30, 2025
3862abb
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Jun 30, 2025
76cbb4f
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Jun 30, 2025
0613f96
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jul 8, 2025
5d02184
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jul 14, 2025
e3b3897
Change parent mesh boundary condition to trigger more code for the test.
SimonCan Jul 14, 2025
9037cf3
Corrected argument for P4estMesh.
SimonCan Jul 15, 2025
bfdc3df
Fixed issue with AnalysisCallbackCoupled.
SimonCan Jul 15, 2025
74843ac
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Jul 15, 2025
98bf870
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Jul 15, 2025
2c9bf4d
Update examples/p4est_2d_dgsem/elixir_advection_coupled.jl
SimonCan Jul 15, 2025
b396227
Removed code for structured meshes.
SimonCan Jul 16, 2025
5ce2067
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jul 16, 2025
69bab29
Merge branch 'sc/p4est-view-coupled' of https://github.com/trixi-fram…
SimonCan Jul 16, 2025
cd0a019
Addedcomments on the mesh views
SimonCan Jul 16, 2025
7bee9aa
Added ncelss for p4est mesh views.
SimonCan Jul 16, 2025
fef8913
Added comment about the boundary conditions.
SimonCan Jul 16, 2025
1561815
Added comment about boundary u-array.
SimonCan Jul 16, 2025
63b5499
Corrected calculation of linf_error for p4est coupled systems.
SimonCan Jul 17, 2025
3c53935
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jul 18, 2025
3bbc298
Update examples/p4est_2d_dgsem/elixir_advection_coupled.jl
SimonCan Jul 23, 2025
2486d1d
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jul 23, 2025
6521fb7
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Sep 25, 2025
fc79fe4
Added parameter cfl_diffusive to calculate_dt for SemidiscretizationC…
SimonCan Sep 25, 2025
b233381
Removed analysis callback.
SimonCan Sep 25, 2025
a4661db
Reinstated analysis callback for coupled p4est simulations.
SimonCan Sep 27, 2025
6657ceb
First steps for coupled analysis callback.
SimonCan Sep 29, 2025
399dd8e
Added more infrastructure for coupled analysis callback.
SimonCan Sep 30, 2025
f787fc6
Removed debugging code.
SimonCan Sep 30, 2025
11a9602
Merge remote-tracking branch 'origin/main' into sc/p4est-view-coupled
SimonCan Sep 30, 2025
ca34af9
Added comments about coupled analysis callbacks.
SimonCan Sep 30, 2025
a2726db
Merge remote-tracking branch 'origin/main' into sc/p4est-view-coupled
SimonCan Oct 1, 2025
93903c3
Merge remote-tracking branch 'origin/main' into sc/p4est-view-coupled
SimonCan Oct 1, 2025
8cb9cfa
Removed unused callback functions.
SimonCan Oct 1, 2025
3c1c853
Removed unused references to u_ode_coupled.
SimonCan Oct 1, 2025
763a842
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 2, 2025
b369fbb
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 2, 2025
74ab2e1
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 6, 2025
7b29c24
Removed unused call of 'show' for analysis callback for p4est mesh vi…
SimonCan Oct 6, 2025
d1db4b4
Applied autoformatter.
SimonCan Oct 6, 2025
2217b09
Merge branch 'sc/p4est-view-coupled' of github.com:trixi-framework/Tr…
SimonCan Oct 6, 2025
cb4c96a
Update src/callbacks_step/analysis.jl
SimonCan Oct 6, 2025
d523377
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Oct 6, 2025
2a94fd2
Update test/test_p4est_2d.jl
SimonCan Oct 6, 2025
8f54ca2
git pushMerge branch 'sc/p4est-view-coupled' of github.com:trixi-fram…
SimonCan Oct 9, 2025
e2596f2
Update test/test_p4est_2d.jl
SimonCan Oct 9, 2025
c9377b2
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Oct 9, 2025
52a5b6c
Update src/callbacks_step/analysis_dg2d.jl
SimonCan Oct 9, 2025
0ad3b72
Update src/callbacks_step/analysis_dg2d.jl
SimonCan Oct 9, 2025
f3a2025
Update src/callbacks_step/analysis_dg2d.jl
SimonCan Oct 9, 2025
e6be6b2
Update src/callbacks_step/analysis_dg2d.jl
SimonCan Oct 9, 2025
db2a2fc
Update src/callbacks_step/analysis_dg2d.jl
SimonCan Oct 9, 2025
02ecbbb
Update src/callbacks_step/analysis_dg2d.jl
SimonCan Oct 9, 2025
ebf7d66
Update src/callbacks_step/analysis.jl
SimonCan Oct 9, 2025
5540a80
Update src/callbacks_step/analysis.jl
SimonCan Oct 9, 2025
775e9cd
Update src/callbacks_step/analysis_dg2d.jl
SimonCan Oct 9, 2025
d4f257f
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 9, 2025
3741953
Removed redundant and conflicting redefinition of the function alloca…
SimonCan Oct 10, 2025
9df2941
Merge branch 'sc/p4est-view-coupled' of github.com:trixi-framework/Tr…
SimonCan Oct 10, 2025
7376820
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 16, 2025
19420b6
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 17, 2025
36c8ddc
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 21, 2025
c4fc630
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 21, 2025
9f5a8e0
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 22, 2025
6a4a378
Removed unused code to keep the CI on code coverage quiet.
SimonCan Oct 23, 2025
0c0e7d6
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 23, 2025
81f4443
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 23, 2025
0592f53
Apply suggestions from code review
DanielDoehring Oct 24, 2025
86fe981
Update src/callbacks_step/analysis.jl
DanielDoehring Oct 24, 2025
3cdc4b5
Update src/callbacks_step/analysis_dg2d.jl
DanielDoehring Oct 24, 2025
3b94c73
Apply suggestions from code review
DanielDoehring Oct 24, 2025
b6fbac5
Apply suggestions from code review
DanielDoehring Oct 24, 2025
87c0ba9
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Oct 27, 2025
6371898
Update src/meshes/p4est_mesh_view.jl
SimonCan Oct 27, 2025
5229329
Semantic formatting.
SimonCan Oct 27, 2025
1e85398
Merge branch 'sc/p4est-view-coupled' of github.com:trixi-framework/Tr…
SimonCan Oct 27, 2025
2d120e6
Added coment explaining the index 2 for the cell interfaces.
SimonCan Oct 27, 2025
b2457c6
Update src/meshes/p4est_mesh_view.jl
SimonCan Oct 27, 2025
b4cdd6a
Update src/meshes/p4est_mesh_view.jl
SimonCan Oct 27, 2025
8f49c69
Update src/semidiscretization/semidiscretization_hyperbolic.jl
SimonCan Oct 27, 2025
035712b
Update src/meshes/p4est_mesh_view.jl
SimonCan Oct 27, 2025
645903b
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Oct 27, 2025
792aed2
Update src/meshes/p4est_mesh_view.jl
SimonCan Oct 29, 2025
c815e5f
Checking now if
SimonCan Oct 29, 2025
4295404
git pushMerge branch 'sc/p4est-view-coupled' of github.com:trixi-fram…
SimonCan Oct 29, 2025
eb6741f
Added comments about finding boundary indices and exceeding the domain.
SimonCan Oct 29, 2025
edc59c9
Added comment about distribution of partial solution vectors onto glo…
SimonCan Oct 29, 2025
de8de9f
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 30, 2025
b3a27b8
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 30, 2025
d742230
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Oct 31, 2025
ea3218b
Added comments to boundary updates.
SimonCan Nov 4, 2025
68471aa
Improved formatting.
SimonCan Nov 4, 2025
89a54d7
Update src/solvers/dgsem_tree/dg_2d.jl
SimonCan Nov 4, 2025
9738567
Update src/solvers/dgsem_tree/dg_2d.jl
SimonCan Nov 5, 2025
0c6443a
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Nov 5, 2025
4c6d3d5
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Nov 5, 2025
6503e53
Removed offending SemidiscretizationCoupled and corrected usage
SimonCan Nov 6, 2025
93ce761
Removed unused code to keep the code overage quiet.
SimonCan Nov 7, 2025
31a1d6a
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Nov 7, 2025
910955b
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Nov 12, 2025
1ed824f
Reintroduced calc_boundary_flux_by_type! functions for type stability.
SimonCan Nov 12, 2025
82f8447
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Nov 19, 2025
630d445
Remove unused code when saving p4est mesh view files.
SimonCan Nov 19, 2025
56aefe7
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Nov 20, 2025
e21e74c
Apply suggestions from code review
DanielDoehring Nov 21, 2025
599545e
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Nov 21, 2025
c13560f
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Nov 25, 2025
b250949
Removed redundant test on p4est mesh views.
SimonCan Nov 26, 2025
896159b
Added @threaded to loop.
SimonCan Nov 26, 2025
b5ed262
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Nov 28, 2025
5ff7e53
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Dec 3, 2025
3240e9b
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Dec 4, 2025
b9b4220
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Dec 5, 2025
2b533b6
Corrected syntax error.
SimonCan Dec 5, 2025
da53cb6
Fixed error with mesh reference.
SimonCan Dec 5, 2025
62461d4
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Dec 8, 2025
b25ee44
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Dec 8, 2025
01bfacf
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Dec 10, 2025
f2e8fab
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Dec 16, 2025
88a7de0
Moved the definition of calc_boundary_flux_by_type into
SimonCan Dec 16, 2025
87e9a08
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jan 7, 2026
f72222e
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jan 7, 2026
884144e
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jan 9, 2026
5d21016
Merge branch 'sc/p4est-view-coupled' of github.com:trixi-framework/Tr…
SimonCan Jan 12, 2026
99d3087
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jan 12, 2026
cb28c33
Removed case for have_nonconservative_terms(equations) == true,
SimonCan Jan 13, 2026
4f4ca3c
git pushMerge branch 'sc/p4est-view-coupled' of github.com:trixi-fram…
SimonCan Jan 13, 2026
bdbdea7
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jan 14, 2026
de459c5
Moved rhs! for mesh::P4estMeshView{2} to the dgsem_p4est directory.
SimonCan Jan 16, 2026
5b881e5
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Jan 20, 2026
72a321a
Removed elixir_advection_meshview.jl, as it was made obsolete
SimonCan Jan 21, 2026
6a0ce4c
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jan 21, 2026
9b2eac8
Update src/solvers/dgsem_p4est/dg_2d.jl
DanielDoehring Jan 22, 2026
2c6a4bf
Mark p4est 2d memory test for elixir_advection_coupled.jl
SimonCan Jan 22, 2026
2f60967
Merge branch 'sc/p4est-view-coupled' of github.com:trixi-framework/Tr…
SimonCan Jan 22, 2026
4b700b4
ADded comment about rhs! for coupled p4est meshes in 2d.
SimonCan Jan 22, 2026
77850b5
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jan 23, 2026
fdaa460
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Jan 23, 2026
1079889
Update src/solvers/dgsem_p4est/dg_2d.jl
DanielDoehring Jan 24, 2026
4b0dae1
Moved the rhs! meant for coupled p4est meshes.
SimonCan Feb 10, 2026
93ea18f
Added comment on the use of
SimonCan Feb 10, 2026
e768d86
Added comment for
SimonCan Feb 10, 2026
b778fac
Added comments on why we need duplicate looking function definitions
SimonCan Feb 10, 2026
6146b9b
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 12, 2026
a9217a5
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 12, 2026
b0cf1c7
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 12, 2026
96cf48b
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 12, 2026
0d483c0
Added comments on how we construct boundaries.name in
SimonCan Feb 12, 2026
d14fdca
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 12, 2026
fdeacda
Merge branch 'sc/p4est-view-coupled' of github.com:trixi-framework/Tr…
SimonCan Feb 12, 2026
385b32a
Corrected Array type.
SimonCan Feb 12, 2026
a693904
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 12, 2026
29cbaff
Added comment about node_indices_to_name translations for 2d, rather …
SimonCan Feb 12, 2026
f21b1c6
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 12, 2026
0e44d54
Merge branch 'sc/p4est-view-coupled' of github.com:trixi-framework/Tr…
SimonCan Feb 12, 2026
ab07c0c
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 12, 2026
0a6bf32
Merge branch 'sc/p4est-view-coupled' of github.com:trixi-framework/Tr…
SimonCan Feb 12, 2026
222f241
Replaced 'id' by 'ids' in global_element_id_to_local.
SimonCan Feb 12, 2026
2f827b2
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 12, 2026
40c83f1
Reverted to previous version.
SimonCan Feb 12, 2026
89a481f
Added time step in output files.
SimonCan Feb 12, 2026
f6e2946
Merge remote-tracking branch 'origin/main' into sc/p4est-view-coupled
SimonCan Feb 16, 2026
ffecd32
Applyed auto formatter.
SimonCan Feb 16, 2026
02fa5a4
Revert "Added comments on why we need duplicate looking function defi…
SimonCan Feb 16, 2026
e3c89d4
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
78d4087
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
c0739a5
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
423064c
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
d22fd58
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
41b15e7
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
d566e41
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
ecf2dcc
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
840e8bb
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
803cd72
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
9b26a22
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
0e2e91b
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
4fad257
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
260f428
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
deace09
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
ffa4a93
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
d11abbe
Update src/solvers/dgsem_p4est/dg_2d.jl
SimonCan Feb 17, 2026
2573add
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Feb 17, 2026
7f59e98
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Feb 17, 2026
1f63e41
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
11bb61d
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
23ed91e
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 17, 2026
20a6c6e
Cleaned up definition of boundary conditions.
SimonCan Feb 18, 2026
da8c04d
Added P4estMeshView to digest_boundary_conditions.
SimonCan Feb 18, 2026
69db921
Renamed 'element' to 'cell'.
SimonCan Feb 19, 2026
8c72bfb
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 19, 2026
c921616
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 19, 2026
3b30ac8
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Feb 19, 2026
d0966c2
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 19, 2026
aec5144
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 19, 2026
43700bf
Update examples/p4est_2d_dgsem/elixir_advection_coupled.jl
SimonCan Feb 19, 2026
ceedf65
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 19, 2026
8f8947c
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 19, 2026
0b50485
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Feb 19, 2026
4d27018
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Feb 19, 2026
d9d5c43
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Feb 19, 2026
fb17f15
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Feb 19, 2026
2c93ea1
Changed hard coded dimension 2 in n_nodes^2 to n_nodes^ndims(mesh.par…
SimonCan Feb 19, 2026
67c7645
Merge branch 'sc/p4est-view-coupled' of github.com:trixi-framework/Tr…
SimonCan Feb 19, 2026
0abf000
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Feb 19, 2026
71c8e36
Update src/semidiscretization/semidiscretization_coupled_p4est.jl
SimonCan Feb 23, 2026
585f154
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Feb 23, 2026
70e6fbb
Fixed mesh name for the mesh loading test.
SimonCan Feb 23, 2026
f9b5d81
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Feb 24, 2026
b6cd8f3
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Feb 24, 2026
61949ef
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Feb 25, 2026
568faa0
Update src/meshes/p4est_mesh_view.jl
sloede Feb 27, 2026
bdcc90b
Update src/meshes/p4est_mesh_view.jl
SimonCan Feb 27, 2026
429dbc6
Reinserted comment about index_to_start_step_2d.
SimonCan Feb 27, 2026
44ee6df
Updated doc string for struct BoundaryConditionCoupledP4est.
SimonCan Feb 27, 2026
6e43b85
Added comment on the parent mesh.
SimonCan Feb 27, 2026
1371fd9
Added comments about p4est mesh view coupled implementation.
SimonCan Feb 27, 2026
f6ddd94
To be more consistent we renamed 'global' to 'parent' where we refer
SimonCan Feb 27, 2026
39cef28
Moved functions related to p4est mesh views into
SimonCan Feb 27, 2026
97adb22
Added comments on how we compute extract_neighbor_ids_parent.
SimonCan Feb 27, 2026
8a48789
Added comments on how we find the cell_index_parent in
SimonCan Feb 27, 2026
2f7d38a
Merge branch 'main' into sc/p4est-view-coupled
sloede Feb 28, 2026
01c9742
Fixed typo.
SimonCan Mar 2, 2026
c57cc22
Merge branch 'sc/p4est-view-coupled' of github.com:trixi-framework/Tr…
SimonCan Mar 2, 2026
0f2539f
Fixed typo.
SimonCan Mar 2, 2026
8849a02
Merge branch 'main' into sc/p4est-view-coupled
sloede Mar 2, 2026
7f62b40
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Mar 2, 2026
800adb3
Removed doubly defined functions calc_boundary_flux_by_type! and calc…
SimonCan Mar 3, 2026
c83a6f0
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Mar 3, 2026
ddf1a0f
Removed double function definition of function calc_boundary_flux_by_…
SimonCan Mar 3, 2026
c2b4f84
Merge branch 'sc/p4est-view-coupled' of github.com:trixi-framework/Tr…
SimonCan Mar 3, 2026
22070a3
Removed option to generate mesh files with different file names for t…
SimonCan Mar 3, 2026
6c8b99a
Merge branch 'main' into sc/p4est-view-coupled
sloede Mar 3, 2026
510186e
Merge branch 'main' into sc/p4est-view-coupled
SimonCan Mar 3, 2026
3969a6c
Merge branch 'main' into sc/p4est-view-coupled
sloede Mar 3, 2026
e8bba4b
Merge branch 'main' into sc/p4est-view-coupled
sloede Mar 3, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 88 additions & 0 deletions examples/p4est_2d_dgsem/elixir_advection_coupled.jl
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
using OrdinaryDiffEqSSPRK, OrdinaryDiffEqLowStorageRK
using Trixi

###############################################################################
# Simplest coupled setup consisting of two non-trivial mesh views.

advection_velocity = (0.2, -0.7)
equations = LinearScalarAdvectionEquation2D(advection_velocity)

# Create DG solver with polynomial degree = 3 and (local) Lax-Friedrichs/Rusanov flux as surface flux
solver = DGSEM(polydeg = 3, surface_flux = flux_lax_friedrichs)

# Define the physical domain for the parent mesh.
coordinates_min = (-1.0, -1.0) # minimum coordinates (min(x), min(y))
coordinates_max = (1.0, 1.0) # maximum coordinates (max(x), max(y))

trees_per_dimension = (8, 8)

# Create parent P4estMesh with 8 x 8 trees and 8 x 8 elements
# Since we couple through the boundaries, the periodicity does not matter here,
# but it is to trigger parts of the code for the test.
parent_mesh = P4estMesh(trees_per_dimension, polydeg = 3,
coordinates_min = coordinates_min,
coordinates_max = coordinates_max,
initial_refinement_level = 0,
periodicity = false)

# Define the mesh views consisting of a small square in the center
# and a square ring around it.
cell_ids1 = vcat((1:18), (23:26), (31:34), (39:42), (47:64))
mesh1 = P4estMeshView(parent_mesh, cell_ids1)
cell_ids2 = vcat((19:22), (27:30), (35:38), (43:46))
mesh2 = P4estMeshView(parent_mesh, cell_ids2)

# Define a trivial coupling function.
coupling_function = (x, u, equations_other, equations_own) -> u

# The mesh is coupled across the physical boundaries, which makes this setup
# effectively double periodic.
boundary_conditions = (; x_neg = BoundaryConditionCoupledP4est(coupling_function),
y_neg = BoundaryConditionCoupledP4est(coupling_function),
y_pos = BoundaryConditionCoupledP4est(coupling_function),
x_pos = BoundaryConditionCoupledP4est(coupling_function))

semi1 = SemidiscretizationHyperbolic(mesh1, equations, initial_condition_convergence_test,
solver,
boundary_conditions = boundary_conditions)
semi2 = SemidiscretizationHyperbolic(mesh2, equations, initial_condition_convergence_test,
solver,
boundary_conditions = boundary_conditions)

# Create a semidiscretization that bundles semi1 and semi2
semi = SemidiscretizationCoupledP4est(semi1, semi2)

###############################################################################
# ODE solvers, callbacks etc.

# Create ODE problem with time span from 0.0 to 2.0
ode = semidiscretize(semi, (0.0, 2.0))

# At the beginning of the main loop, the SummaryCallback prints a summary of the simulation setup
# and resets the timers
summary_callback = SummaryCallback()

# The AnalysisCallback allows to analyse the solution in regular intervals and prints the results
# We require this definition for the test, even though we don't use it in the CallbackSet.
analysis_callback1 = AnalysisCallback(semi1, interval = 100)
analysis_callback2 = AnalysisCallback(semi2, interval = 100)
analysis_callback = AnalysisCallbackCoupledP4est(semi, analysis_callback1,
analysis_callback2)

# The SaveSolutionCallback allows to save the solution to a file in regular intervals
save_solution = SaveSolutionCallback(interval = 100,
solution_variables = cons2prim)

# The StepsizeCallback handles the re-calculation of the maximum Δt after each time step
stepsize_callback = StepsizeCallback(cfl = 1.6)

# Create a CallbackSet to collect all callbacks such that they can be passed to the ODE solver
callbacks = CallbackSet(summary_callback, save_solution, stepsize_callback)

###############################################################################
# run the simulation

# OrdinaryDiffEq's `solve` method evolves the solution in time and executes the passed callbacks
sol = solve(ode, CarpenterKennedy2N54(williamson_condition = false);
dt = 1.0, # solve needs some value here but it will be overwritten by the stepsize_callback
ode_default_options()..., callback = callbacks);
65 changes: 0 additions & 65 deletions examples/p4est_2d_dgsem/elixir_advection_meshview.jl

This file was deleted.

7 changes: 4 additions & 3 deletions src/Trixi.jl
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ include("semidiscretization/semidiscretization_hyperbolic.jl")
include("semidiscretization/semidiscretization_hyperbolic_parabolic.jl")
include("semidiscretization/semidiscretization_euler_acoustics.jl")
include("semidiscretization/semidiscretization_coupled.jl")
include("semidiscretization/semidiscretization_coupled_p4est.jl")
include("time_integration/time_integration.jl")
include("callbacks_step/callbacks_step.jl")
include("callbacks_stage/callbacks_stage.jl")
Expand Down Expand Up @@ -233,7 +234,7 @@ export boundary_condition_do_nothing,
BoundaryConditionNavierStokesWall,
NoSlip, Slip,
Adiabatic, Isothermal,
BoundaryConditionCoupled
BoundaryConditionCoupled, BoundaryConditionCoupledP4est

export initial_condition_convergence_test, source_terms_convergence_test,
source_terms_lorentz, source_terms_collision_ion_electron,
Expand Down Expand Up @@ -304,14 +305,14 @@ export SemidiscretizationEulerGravity, ParametersEulerGravity,
timestep_gravity_erk53_3Sstar!,
timestep_gravity_carpenter_kennedy_erk54_2N!

export SemidiscretizationCoupled
export SemidiscretizationCoupled, SemidiscretizationCoupledP4est

export SummaryCallback, SteadyStateCallback, AnalysisCallback, AliveCallback,
SaveRestartCallback, SaveSolutionCallback, TimeSeriesCallback, VisualizationCallback,
AveragingCallback,
AMRCallback, StepsizeCallback,
GlmSpeedCallback, LBMCollisionCallback, EulerAcousticsCouplingCallback,
TrivialCallback, AnalysisCallbackCoupled,
TrivialCallback, AnalysisCallbackCoupled, AnalysisCallbackCoupledP4est,
AnalysisSurfaceIntegral, DragCoefficientPressure2D, LiftCoefficientPressure2D,
DragCoefficientShearStress2D, LiftCoefficientShearStress2D,
DragCoefficientPressure3D, LiftCoefficientPressure3D
Expand Down
3 changes: 1 addition & 2 deletions src/callbacks_step/analysis.jl
Original file line number Diff line number Diff line change
Expand Up @@ -705,8 +705,7 @@ end
# have `VariableViscous` available.
function analyze(quantity::AnalysisSurfaceIntegral{Variable},
du, u, t,
semi::SemidiscretizationHyperbolicParabolic) where {
Variable <:
semi::SemidiscretizationHyperbolicParabolic) where {Variable <:
VariableViscous}
mesh, equations, solver, cache = mesh_equations_solver_cache(semi)
equations_parabolic = semi.equations_parabolic
Expand Down
3 changes: 2 additions & 1 deletion src/callbacks_step/analysis_dg2d.jl
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,8 @@ end

function integrate_via_indices(func::Func, u,
mesh::Union{StructuredMesh{2}, StructuredMeshView{2},
UnstructuredMesh2D, P4estMesh{2},
UnstructuredMesh2D,
P4estMesh{2}, P4estMeshView{2},
T8codeMesh{2}},
equations, dg::DGSEM, cache,
args...; normalize = true) where {Func}
Expand Down
Loading
Loading