Skip to content

Comments

Bump compat bound for RecursiveArrayTools.jl#2306

Merged
ranocha merged 1 commit intotrixi-framework:mainfrom
jlchan:jc/bump_recursive_array_tools
Mar 16, 2025
Merged

Bump compat bound for RecursiveArrayTools.jl#2306
ranocha merged 1 commit intotrixi-framework:mainfrom
jlchan:jc/bump_recursive_array_tools

Conversation

@jlchan
Copy link
Contributor

@jlchan jlchan commented Mar 15, 2025

v3.31.1 has SciML/RecursiveArrayTools.jl#426 and SciML/RecursiveArrayTools.jl#425 implemented to fix SciML/OrdinaryDiffEq.jl#2625 (comment).

I'm opening this PR to check if this breaks any CI with StructArray-based DGMulti solvers.

@jlchan jlchan marked this pull request as draft March 15, 2025 17:38
@github-actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@codecov
Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.89%. Comparing base (6f6aeff) to head (9b7e3c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2306   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files         495      495           
  Lines       40499    40499           
=======================================
  Hits        39239    39239           
  Misses       1260     1260           
Flag Coverage Δ
unittests 96.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlchan jlchan marked this pull request as ready for review March 15, 2025 18:13
@huiyuxie
Copy link
Member

LGTM please approve @ranocha

@huiyuxie huiyuxie requested review from huiyuxie and ranocha March 16, 2025 06:06
@ranocha ranocha merged commit 3c3e7f7 into trixi-framework:main Mar 16, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Solvers using VectorOfArray behave differently for different parent array types

3 participants