CompatHelper: bump compat for DiffEqCallbacks to 4, (keep existing compat)#2091
Closed
github-actions[bot] wants to merge 3 commits intomainfrom
Closed
CompatHelper: bump compat for DiffEqCallbacks to 4, (keep existing compat)#2091github-actions[bot] wants to merge 3 commits intomainfrom
github-actions[bot] wants to merge 3 commits intomainfrom
Conversation
36fca4c to
85a4659
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2091 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 470 470
Lines 37512 37512
=======================================
Hits 36140 36140
Misses 1372 1372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sloede
approved these changes
Sep 28, 2024
Member
|
The tests pass, but then again, they seem to be using DiffEqCallbacks v2.37.0. Should we merge anyways? |
ranocha
requested changes
Oct 2, 2024
Member
ranocha
left a comment
There was a problem hiding this comment.
No. We should wait until dependencies have been updated to test the new version.
Member
|
It's still using the old version, see https://github.com/trixi-framework/Trixi.jl/actions/runs/11139766106/job/30957092767?pr=2091#step:7:123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
DiffEqCallbackspackage from2.25to2.25, 4.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.