Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid allocations in boundary flux for parabolic RHS #1594

Merged
merged 9 commits into from
Aug 8, 2023

Conversation

DanielDoehring
Copy link
Contributor

The previous implementation caused allocations due to the slicing.

jlchan
jlchan previously approved these changes Jul 31, 2023
Copy link
Contributor

@jlchan jlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch to avoid allocations.

@DanielDoehring
Copy link
Contributor Author

Credits for pin-pointing the allocations go to @jlchan, I just noticed this while working on the mortars & amr for parabolic terms.

jlchan
jlchan previously approved these changes Aug 7, 2023
@ranocha ranocha enabled auto-merge (squash) August 8, 2023 07:29
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1594 (d1e4dad) into main (6c97c48) will increase coverage by 6.73%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #1594      +/-   ##
==========================================
+ Coverage   89.40%   96.13%   +6.73%     
==========================================
  Files         401      401              
  Lines       33041    33072      +31     
==========================================
+ Hits        29539    31791    +2252     
+ Misses       3502     1281    -2221     
Flag Coverage Δ
unittests 96.13% <75.00%> (+6.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/tree_2d_dgsem/elixir_navierstokes_shear_layer.jl 0.00% <0.00%> (ø)
...s/tree_2d_dgsem/elixir_navierstokes_convergence.jl 100.00% <100.00%> (ø)
...s/tree_3d_dgsem/elixir_navierstokes_convergence.jl 100.00% <100.00%> (ø)
src/solvers/dgsem_tree/containers_2d.jl 97.73% <100.00%> (+45.10%) ⬆️
src/solvers/dgsem_tree/containers_3d.jl 98.53% <100.00%> (ø)

... and 37 files with indirect coverage changes

@ranocha ranocha merged commit ddf0892 into trixi-framework:main Aug 8, 2023
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants