-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid allocations in boundary flux
for parabolic RHS
#1594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice catch to avoid allocations.
Credits for pin-pointing the allocations go to @jlchan, I just noticed this while working on the mortars & amr for parabolic terms. |
40b2796
Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1594 +/- ##
==========================================
+ Coverage 89.40% 96.13% +6.73%
==========================================
Files 401 401
Lines 33041 33072 +31
==========================================
+ Hits 29539 31791 +2252
+ Misses 3502 1281 -2221
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The previous implementation caused allocations due to the slicing.