-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enstrophy for 2D Navier-Stokes #1591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
Codecov Report
@@ Coverage Diff @@
## main #1591 +/- ##
===========================================
+ Coverage 83.00% 96.07% +13.08%
===========================================
Files 400 401 +1
Lines 33019 33088 +69
===========================================
+ Hits 27405 31789 +4384
+ Misses 5614 1299 -4315
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hm, the CI MPI test for mac fails when run with coverage, the non-covered version seems to be fine. |
Could be related to #1590 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for adding this functionality!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This PR extends functionalities existing in 3D to 2D.