-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow periodic FDSBP operators #1570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall with only minor suggestions/questions
Codecov Report
@@ Coverage Diff @@
## main #1570 +/- ##
==========================================
+ Coverage 89.15% 96.15% +7.00%
==========================================
Files 383 384 +1
Lines 31949 31998 +49
==========================================
+ Hits 28483 30767 +2284
+ Misses 3466 1231 -2235
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I enabled the use of fully periodic FDSBP operators. It would be nice if you could take a look, @gregorgassner, since both @andrewwinters5000 and @sloede are on vacation.