Fix constraints in isExpensiveCat#9995
Merged
Merged
Conversation
This was referenced Apr 10, 2026
peterbell10
reviewed
Apr 14, 2026
neildhar
force-pushed
the
neildhar/pr9995
branch
from
16d268e to
74ee3ea
Compare
peterbell10
approved these changes
Apr 14, 2026
isExpensiveCat does not reflect the constraint we have in lowering, which is that the number of unique result elements per thread must be equal to the total number of unique operand elements per thread. This means that we can sometimes fold `CatOp` into layout conversions that have destination layouts that violate this requirement. Rename it to `isLegalCatEncoding` to reflect that it is actually a correctness requirement, and update it to reflect the actual constraint.
neildhar
force-pushed
the
neildhar/pr9995
branch
from
74ee3ea to
2675aa1
Compare
raymondtay
pushed a commit
to raymondtay/triton
that referenced
this pull request
Apr 18, 2026
isExpensiveCat does not reflect the constraint we have in lowering, which is that the number of unique result elements per thread must be equal to the total number of unique operand elements per thread. This means that we can sometimes fold `CatOp` into layout conversions that have destination layouts that violate this requirement. Rename it to `isLegalCatEncoding` to reflect that it is actually a correctness requirement, and update it to reflect the actual constraint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isExpensiveCat does not reflect the constraint we have in lowering,
which is that the number of unique result elements per thread must be
equal to the total number of unique operand elements per thread. This
means that we can sometimes fold
CatOpinto layout conversions thathave destination layouts that violate this requirement.
Rename it to
isLegalCatEncodingto reflect that it is actually acorrectness requirement, and update it to reflect the actual constraint.