Skip to content

[BACKEND] Remove barrier from TMEMCopy#9987

Merged
lezcano merged 1 commit into
mainfrom
copy_no_barrier
Apr 10, 2026
Merged

[BACKEND] Remove barrier from TMEMCopy#9987
lezcano merged 1 commit into
mainfrom
copy_no_barrier

Conversation

@lezcano
Copy link
Copy Markdown
Contributor

@lezcano lezcano commented Apr 10, 2026

There is no reason why we should fuse these two. tcgen05_mma has a fused
barrier because that way the codegen is better, but this is not the case
for TMEMCopy. Also we rarely would want to do a tmem_copy and then wait
on it without a tcgen05_mma, so out it goes.

There is no reason why we should fuse these two. tcgen05_mma has a fused
barrier because that way the codegen is better, but this is not the case
for TMEMCopy. Also we rarely would want to do a tmem_copy and then wait
on it without a tcgen05_mma, so out it goes.

This way we also are able to remove things like
```
  } else if (isa<ttng::TMEMCopyOp>(op)) {
    // TMEMCopy does not have descs (empty)
```
which already smelled weird.
@lezcano lezcano merged commit d166045 into main Apr 10, 2026
9 checks passed
@lezcano lezcano deleted the copy_no_barrier branch April 10, 2026 10:03
@masahi
Copy link
Copy Markdown
Collaborator

masahi commented Apr 10, 2026

This op predates the standalone tcgen05 commit op. So without the barrier, we couldn't have written a tmem_copy only test. But yes, now this is no longer needed.

plognjen pushed a commit to plognjen/triton that referenced this pull request Apr 14, 2026
There is no reason why we should fuse these two. tcgen05_mma has a fused
barrier because that way the codegen is better, but this is not the case
for TMEMCopy. Also we rarely would want to do a tmem_copy and then wait
on it without a tcgen05_mma, so out it goes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants