Fix inferDstEncoding for rank 1 reduction#9925
Merged
Merged
Conversation
This was referenced Apr 4, 2026
lezcano
approved these changes
Apr 4, 2026
Contributor
lezcano
left a comment
lezcano
left a comment
There was a problem hiding this comment.
sg, but do we really need two mlir tests?
Collaborator
Author
I think there's some value in guarding against the bug in both places I found it, in case the code is refactored in the future. I don't feel strongly though. |
neildhar
force-pushed
the
neildhar/pr9924
branch
from
8f111e7 to
0fd4805
Compare
`inferDstEncoding` currently tries to unconditionally build a sliced encoding from the src encoding it is given. But this is incorrect if the source is rank 1, since we can't take a slice of a rank 1 tensor.
neildhar
force-pushed
the
neildhar/pr9924
branch
from
0fd4805 to
2d5292a
Compare
plognjen
pushed a commit
to plognjen/triton
that referenced
this pull request
Apr 14, 2026
`inferDstEncoding` currently tries to unconditionally build a sliced encoding from the src encoding it is given. But this is incorrect if the source is rank 1, since we can't take a slice of a rank 1 tensor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inferDstEncodingcurrently tries to unconditionally build a slicedencoding from the src encoding it is given. But this is incorrect if the
source is rank 1, since we can't take a slice of a rank 1 tensor.