Include python/src headers in installation artifacts#9847
Merged
Conversation
abrown
requested review from
Jokeren,
antiagainst,
ptillet and
zhanglx13
as code owners
abrown
force-pushed
the
fix-exported-headers-again
branch
from
f11ef3d to
487d903
Compare
This currently copies over the following headers to the installation artifacts: - `build/install/include/python/src/passes.h` - `build/install/include/python/src/ir.h` - `build/install/include/python/triton/experimental/gsan/src/GSan.h`
The `Dump.hpp` and `GetEnv.hpp` files were not being included in the installation artifacts because of their file extension: `.hpp` instead of `.h`. This renames this to have an extension more in line with other headers in the project.
abrown
force-pushed
the
fix-exported-headers-again
branch
from
487d903 to
85ea850
Compare
peterbell10
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9626 added a way to construct custom ops by depending on
python/src/ir.h, a header not present in the installation artifacts (#9534) used for building plugins in triton-ext. If we don't want to move this header to a directory already packaged up by CMake (#9826), we could additionally package up the headers in thepythondirectory instead: this change does exactly that.In doing so, it also exposed another problem in how we package up these installation artifacts. We currently only package up files ending in
*.h, soDump.hppandGetEnv.hppwere not included. To fix this, this change renames these files toDump.handGetEnv.hwhich seems more in line with the rest of the project.