Skip to content

[triton-ext] Fix garbage string in reported errors #9687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lezcano merged 1 commit into from
Mar 10, 2026
+10 −13
Merged

[triton-ext] Fix garbage string in reported errors #9687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions lib/Tools/PluginUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

llvm::Error TritonPlugin::checkLibraryValid(const std::string &error) const {
if (!library.isValid()) {
auto msg = llvm::Twine("Failed to load plugin library: " + error + "\n");
return llvm::createStringError(msg);
return llvm::createStringError(
llvm::Twine("Failed to load plugin library: ") + error);
}
return llvm::Error::success();
}
Expand All @@ -14,8 +14,8 @@ TritonPlugin::getAddressOfSymbol(const std::string &symbol) const {
return isValid;
intptr_t getDetailsFn = (intptr_t)library.getAddressOfSymbol(symbol.c_str());
if (!getDetailsFn) {
auto msg = llvm::Twine("Failed to get symbol: " + symbol + "\n");
return llvm::createStringError(msg);
return llvm::createStringError(llvm::Twine("Failed to get symbol: ") +
symbol);
}
return getDetailsFn;
}
Expand All @@ -25,11 +25,9 @@ TritonPlugin::checkAPIResult(TritonPluginResult result,
const char *handle) const {
if (result == TP_SUCCESS)
return TP_SUCCESS;
std::string msg;
llvm::raw_string_ostream os(msg);
os << "Failed to add/register plugin pass (" << handle
<< ") to pass manager, error code: " << result;
return llvm::createStringError(msg);
return llvm::createStringError(
llvm::Twine("Failed to add/register a plugin pass (") + handle +
"), error code: " + std::to_string(result));
}

std::runtime_error TritonPlugin::err2exp(llvm::Error Err) {
Expand Down Expand Up @@ -108,10 +106,9 @@ llvm::Expected<TritonPluginResult> TritonPlugin::enumeratePyBindHandles(

if (result == TP_SUCCESS)
return TP_SUCCESS;
std::string msg;
llvm::raw_string_ostream os(msg);
os << "Failed to retrive plugin pass handles, error code: " << result;
return llvm::createStringError(msg);
return llvm::createStringError(
llvm::Twine("Failed to retrieve plugin pass handles, error code: ") +
std::to_string(result));
}

llvm::Expected<TritonPluginResult>
Expand Down
Loading