[AMD] Enable AsyncCopy by default on gfx950 and gfx1250#9087
Merged
Conversation
antiagainst
approved these changes
Dec 23, 2025
Contributor
|
This PR broke and perf-regressed multiple Tritonbench tests: |
Member
|
Thanks for the report! That's sort of expected. I commented on the issue. |
agron911
added a commit
to agron911/triton
that referenced
this pull request
Apr 24, 2026
…fx950 and gfx1250 (#9087)' (facebookexperimental#1335) Summary: Pull Request resolved: facebookexperimental#1335 This is a cherry-pick of an upstream PR: triton-lang/triton#9087 Upstream commit message: ``` > [AMD] Enable AsyncCopy by default for gfx950 and gfx1250 (#9087) > Enables `ttg.async_copy_global_to_local` for pipelined loads by default > on `gfx950` and `gfx1250`. > This increases LDS consumption because we replace one register buffer > with an additional LDS buffer. After this change, the number of LDS > buffers is equal to `num_stages` (previously it was `num_stages - 1`). > Therefore, some test configs need to be skipped because we run out of > shared memory capacity on `gfx950`. > --------- > Co-authored-by: Lei Zhang <antiagainst@gmail.com> ``` ***Do not remove the following line from this commit*** Reactor Cherry-pick Revision: b54cb94 Diff Comparison: https://www.internalfb.com/intern/paste/P2283343700/ --- This diff was generated by running: ``` buck run fbcode//triton/tools/reactor:reactor -- cherrypick --num-commits 1 --no-submit ``` Reviewed By: sfzhu93 Differential Revision: D101982809
meta-codesync Bot
pushed a commit
to facebookexperimental/triton
that referenced
this pull request
Apr 24, 2026
…fx950 and gfx1250 (#9087)' (#1335) Summary: Pull Request resolved: #1335 This is a cherry-pick of an upstream PR: triton-lang/triton#9087 Upstream commit message: ``` > [AMD] Enable AsyncCopy by default for gfx950 and gfx1250 (#9087) > Enables `ttg.async_copy_global_to_local` for pipelined loads by default > on `gfx950` and `gfx1250`. > This increases LDS consumption because we replace one register buffer > with an additional LDS buffer. After this change, the number of LDS > buffers is equal to `num_stages` (previously it was `num_stages - 1`). > Therefore, some test configs need to be skipped because we run out of > shared memory capacity on `gfx950`. > --------- > Co-authored-by: Lei Zhang <antiagainst@gmail.com> ``` ***Do not remove the following line from this commit*** Reactor Cherry-pick Revision: b54cb94 Diff Comparison: https://www.internalfb.com/intern/paste/P2283343700/ --- This diff was generated by running: ``` buck run fbcode//triton/tools/reactor:reactor -- cherrypick --num-commits 1 --no-submit ``` Reviewed By: sfzhu93 Differential Revision: D101982809 fbshipit-source-id: 5af1287a77f46b618c2cd266fcfe2eb3549a6c7a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables
ttg.async_copy_global_to_localfor pipelined loads by default ongfx950andgfx1250.This increases LDS consumption because we replace one register buffer with an additional LDS buffer. After this change, the number of LDS buffers is equal to
num_stages(previously it wasnum_stages - 1). Therefore, some test configs need to be skipped because we run out of shared memory capacity ongfx950.Fixes https://github.com/ROCm/triton-internal/issues/1020