Revert "[RELAND][Triton] Make tl.cat deterministic by using permute+reshape+join and remove CatOp"#8878
Merged
Conversation
…+reshape…" This reverts commit 20f5bc6.
ThomasRaoux
requested review from
antiagainst,
peterbell10,
ptillet and
zhanglx13
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ThomasRaoux
deleted the
revert-8854-revert-8777-revert-8769-mogball/cat
branch
|
🤣may I ask why ? I saw official document changed twice in three or four days ..... |
Collaborator
Author
it's causing performance regressions we are trying to fix |
meta-codesync Bot
pushed a commit
to facebookexperimental/triton
that referenced
this pull request
Apr 10, 2026
…deterministic by using permute+reshape+join and remove `CatOp`" (#8878)' Summary: This is a cherry-pick of an upstream PR: triton-lang/triton#8878 Upstream commit message: ``` > Revert "[RELAND][Triton] Make `tl.cat` deterministic by using permute+reshape+join and remove `CatOp`" (#8878) > sadly need to revert this PR again :( triton-lang/triton#8854 ``` Diff Comparison: https://www.internalfb.com/intern/paste/P2265109153/ ***Do not remove the following line from this commit*** Reactor Cherry-pick Revision: 36e8f65 --- This diff was generated by running: ``` buck run fbcode//triton/tools/reactor:reactor -- cherrypick --num-commits 1 --no-submit ``` Reviewed By: njriasan Differential Revision: D99910037 fbshipit-source-id: 299cf77b79640b7da39f563b39a946c6f9dd482d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sadly need to revert this PR again :( #8854