[BACKEND] Apply padding to memdesc_subview for PaddedSharedEncoding#7404
Merged
antiagainst merged 3 commits intotriton-lang:mainfrom Jul 7, 2025
Merged
Conversation
lezcano
approved these changes
Jul 7, 2025
antiagainst
approved these changes
Jul 7, 2025
antiagainst
pushed a commit
that referenced
this pull request
Jul 29, 2025
#7622 introduced `ttg.memdesc_index` which applies a constant offset to the base pointer of the smem object. For padded layouts we need to add padding based on the offset, similar to what #7404 did for the old subview operation. I also adjusted the lit test to check we actually generate padding from the ttg.memdesc_index. The previous version did not fail because it matched the lowering of the `ttg.local_load/store` as well.
stadlmax
pushed a commit
to stadlmax/triton
that referenced
this pull request
Aug 4, 2025
…7696) triton-lang#7622 introduced `ttg.memdesc_index` which applies a constant offset to the base pointer of the smem object. For padded layouts we need to add padding based on the offset, similar to what triton-lang#7404 did for the old subview operation. I also adjusted the lit test to check we actually generate padding from the ttg.memdesc_index. The previous version did not fail because it matched the lowering of the `ttg.local_load/store` as well.
stadlmax
pushed a commit
to stadlmax/triton
that referenced
this pull request
Aug 4, 2025
…7696) triton-lang#7622 introduced `ttg.memdesc_index` which applies a constant offset to the base pointer of the smem object. For padded layouts we need to add padding based on the offset, similar to what triton-lang#7404 did for the old subview operation. I also adjusted the lit test to check we actually generate padding from the ttg.memdesc_index. The previous version did not fail because it matched the lowering of the `ttg.local_load/store` as well.
tie-pilot-qxw
pushed a commit
to tie-pilot-qxw/triton
that referenced
this pull request
Aug 30, 2025
) For padded layouts introduced by triton-lang#7212 we need to add the padding to the base ptr of the resulting subview.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For padded layouts introduced by #7212 we need to add the padding to the base ptr of the resulting subview.