-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[BACKEND] Support fp64 simt fma for common use and fp64 mma for SM80/SM90. #7310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a5129a0
[BACKEND] Support fp64 simt fma for common use and fp64 mma for SM80.
kzwrime abc3d03
[BACKEND] Replace (bitwidth < 32 ? 32 / bitwidth : 1) with std::max(3…
kzwrime ac506a5
[BACKEND] Replace (bitwidth < 32 ? 32 : bitwidth) with std::max(32u, …
kzwrime d8f9cef
[BACKEND] Fix format
kzwrime 253f078
[BACKEND] Better check for whether fp64 MMA is supported
kzwrime 2f577af
[BACKEND] Revert changes in lowerLdStMatrix
kzwrime a1aef12
[BACKEND] Revert changes in lowerSharedToDotOperandTransLL
kzwrime 041b421
[TESTS] Check cuda_shared_mem_avail using shared_memory_per_block_opt…
kzwrime a963038
[BACKEND] Remove useless include in MMAv2
kzwrime 04ae6e8
[BACKEND] More fp64 MMA support
kzwrime 143f1d0
[TEST] Enable test_simple_matmul[float64] on all cuda archs and fix f…
kzwrime 4362933
[BACKEND] Improved the comments regarding F64 MMA/FMA selection.
kzwrime 77c61bd
[BACKEND] Unify SM80 F64 MMA with SM90 and remove the design of MMAv2.2
kzwrime 6ee5178
[BACKEND] Revert the change of versionMinor
kzwrime 04bf98f
[TESTS] Revert the change of versionMinor
kzwrime e6bf188
[TESTS] Fix: prohibite mmav5 check on float64 in test_simple_matmul
kzwrime b4187d1
Merge branch 'main' into dot-fp64-mma
kzwrime 87261ca
[BACKEND] Restrict the F64 case of tileBitWidthK to isAmpere() && bit…
kzwrime File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused about this last change. What's the context for the Ampere tile to be larger? I thought it was the smaller one.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It used to be
auto tileBitWidthK = isHopperF64() ? (4 * 256) : (4 * 64), but later it was designed to repeat SM80 fp64 m8n8k4 (2,1,4)=8 times, making it the same as SM90 fp64 mma m16n8k16, thereby achieving a unified mmav2 fp64 processing logic.As previously discussed:
We needed to distinguish SM90 fp64 mma, so initially I designed it with versionMajor=2, versionMinor=2 and used isHopperF64() to identify this information, as #7310 (comment) shows.
@ThomasRaoux thought introducing a new versionMinor would be more confusing (#7310 (comment)), so I repeat SM80 fp64 m8n8k4 (2,1,4)=8 times, making it the same as SM90 fp64 mma m16n8k16, thereby achieving a unified mmav2 fp64 processing logic ( #7310 (comment)).