Conversation
Finally got around to implement `divideLeft`. I rescued and adapted the `divideRight` tests from #5170 and added a few more. As discussed in the inline comment, there is some ambiguity when it comes to define the quotient if the quotient has dimensions of size one. You can basically keep them or remove them and both of them would give you a LinearLayout such that `A = B * C`. We choose to keep them, as removing them would make the behaviour too unpredictable. The invariant here is that the dimensions of the result of `leftDivide` are the same as the dimensions of the left input. The right input may have less dimensions than the right input tho.
Now the duality between forward and backward pass should be crystal clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally got around to implement
divideLeft. I rescued and adapted thedivideRighttests from #5170and added a few more.
As discussed in the inline comment, there is some ambiguity when it
comes to define the quotient if the quotient has dimensions of size one.
You can basically keep them or remove them and both of them would give
you a LinearLayout such that
A = B * C. We choose to keep them, asremoving them would make the behaviour too unpredictable. The invariant
here is that the dimensions of the result of
leftDivideare the sameas the dimensions of the left input. The right input may have less
dimensions than the right input tho.