[CI] use popd/pushd instead of cd#5057
Closed
leseb wants to merge 1 commit into
Closed
Conversation
Replaced instances of `cd` with `pushd` and `popd` to manage directory changes, ensuring the script maintains a clean and predictable directory state. This change improves readability and maintainability by using directory stack operations, allowing easy return to the original directory after performing tasks in different directories. Signed-off-by: Sébastien Han <seb@redhat.com>
Contributor
|
I don't think it's worth fixing the problems. These scripts have not been used in our testing pipeline for a while. We have completely offloaded torch inductor tests to Meta |
Contributor
Author
|
@Jokeren, should we remove the tests, then? That way, it's clear for the future that no one should attempt to modify them. |
Contributor
|
Sure |
Contributor
Author
#5073. PTAL, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced instances of
cdwithpushdandpopdto manage directory changes, ensuring the script maintains a clean and predictable directory state. This change improves readability and maintainability by using directory stack operations, allowing easy return to the original directory after performing tasks in different directories.The core Triton is a small number of people, and we receive many PRs (thank
you!). To help us review your code more quickly, if you are a new
contributor (less than 3 PRs merged) we ask that you complete the following
tasks and include the filled-out checklist in your PR description.
Signed-off-by: Sébastien Han seb@redhat.com
rules.
pre-commit run --from-ref origin/main --to-ref HEAD./testforlittests/unittestfor C++ tests/python/testfor end-to-end testslittests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)