Skip to content

[CI] use popd/pushd instead of cd#5057

Closed
leseb wants to merge 1 commit into
triton-lang:mainfrom
leseb:use-popd-pushd
Closed

[CI] use popd/pushd instead of cd#5057
leseb wants to merge 1 commit into
triton-lang:mainfrom
leseb:use-popd-pushd

Conversation

@leseb
Copy link
Copy Markdown
Contributor

@leseb leseb commented Nov 4, 2024

Replaced instances of cd with pushd and popd to manage directory changes, ensuring the script maintains a clean and predictable directory state. This change improves readability and maintainability by using directory stack operations, allowing easy return to the original directory after performing tasks in different directories.

The core Triton is a small number of people, and we receive many PRs (thank
you!). To help us review your code more quickly, if you are a new
contributor (less than 3 PRs merged) we ask that you complete the following
tasks and include the filled-out checklist in your PR description.

Signed-off-by: Sébastien Han seb@redhat.com

  • I am not making a trivial change, such as fixing a typo in a comment.
  • I have written a PR description following these
    rules.
  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.
  • Select one of the following.
    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because it's changing the CI scripts.
  • Select one of the following.
    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

Replaced instances of `cd` with `pushd` and `popd` to manage directory
changes, ensuring the script maintains a clean and predictable directory
state. This change improves readability and maintainability by using
directory stack operations, allowing easy return to the original
directory after performing tasks in different directories.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb requested a review from ptillet as a code owner November 4, 2024 13:33
@Jokeren
Copy link
Copy Markdown
Contributor

Jokeren commented Nov 4, 2024

I don't think it's worth fixing the problems. These scripts have not been used in our testing pipeline for a while. We have completely offloaded torch inductor tests to Meta

@Jokeren Jokeren closed this Nov 4, 2024
@leseb
Copy link
Copy Markdown
Contributor Author

leseb commented Nov 5, 2024

@Jokeren, should we remove the tests, then? That way, it's clear for the future that no one should attempt to modify them.

@Jokeren
Copy link
Copy Markdown
Contributor

Jokeren commented Nov 5, 2024

Sure

@leseb
Copy link
Copy Markdown
Contributor Author

leseb commented Nov 5, 2024

have completely offloaded torch inductor tests to Meta

#5073. PTAL, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants