[AMD][BACKEND] Switch to code object v5 #5005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAUT
commented
Oct 29, 2024
zhanglx13
reviewed
Oct 30, 2024
AlexAUT
force-pushed
the
switchToCOV5
branch
4 times, most recently
from
8cf7619 to
d5b5d81
Compare
AlexAUT
force-pushed
the
switchToCOV5
branch
from
d5b5d81 to
36fa63c
Compare
zhanglx13
reviewed
Nov 20, 2024
antiagainst
requested changes
Nov 22, 2024
Collaborator
antiagainst
left a comment
antiagainst
left a comment
There was a problem hiding this comment.
Thanks for figuring out the docker issue! We need to separate this pull request into two parts--one updating the docker, the other to follow to switch to COv5.
7 tasks
antiagainst
requested changes
Dec 4, 2024
antiagainst
approved these changes
Dec 12, 2024
antiagainst
added a commit
to antiagainst/triton
that referenced
this pull request
Dec 13, 2024
This reverts commit 91302ea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to code object v5 which requires to bump
rocmto6.2+to avoid segfaults fordevice_printsandtl.num_programs.The added unit test covers the previous
segfaultwithdevice_printsfor 2d tensors.This is a preparation to test llvm/llvm-project@c4d8920
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)