[AMD] NFC: Refactor AccelerateAMDMatmul patterns#4985
Merged
antiagainst merged 1 commit intotriton-lang:mainfrom Oct 24, 2024
Merged
[AMD] NFC: Refactor AccelerateAMDMatmul patterns#4985antiagainst merged 1 commit intotriton-lang:mainfrom
antiagainst merged 1 commit intotriton-lang:mainfrom
Conversation
This commit refactors the AccelerateAMDMatmul patterns in prep for mxfp support so that upcoming changes can be easier to review.
antiagainst
force-pushed
the
amd-mxfp-refactor
branch
from
e785eef to
dca8747
Compare
zhanglx13
approved these changes
Oct 24, 2024
Collaborator
zhanglx13
left a comment
zhanglx13
left a comment
There was a problem hiding this comment.
LGTM! Looking forward to the mxfp support :)
lezcano
added a commit
to lezcano/triton
that referenced
this pull request
Oct 24, 2024
When building with clang 10, it complains that it doesn't know how to convert SmallVector<..., 2> into SmallVector<..., 3>. Introduced in triton-lang#4985
Luosuu
pushed a commit
to Luosuu/triton
that referenced
this pull request
Nov 13, 2024
This commit refactors the AccelerateAMDMatmul patterns in prep for mxfp support.
guacamoleo
pushed a commit
to guacamoleo/triton
that referenced
this pull request
Nov 14, 2024
This commit refactors the AccelerateAMDMatmul patterns in prep for mxfp support.
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
This commit refactors the AccelerateAMDMatmul patterns in prep for mxfp support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the AccelerateAMDMatmul patterns in prep for mxfp support so that upcoming changes can be easier to review.