Skip to content

[BACKEND] Add a knob to fall back to the legacy mma layout conversion code #4561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pawelszczerbuk merged 2 commits into from
Aug 23, 2024
Merged

[BACKEND] Add a knob to fall back to the legacy mma layout conversion code #4561

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75e5ddf
Update
Jokeren Aug 23, 2024
23e2ba8
Update
Jokeren Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/Conversion/TritonGPUToLLVM/ConvertLayoutOpToLLVM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ using ::mlir::LLVM::linearize;

using namespace mlir::triton::gpu;

// XXX(Keren): A temporary knob to control the use of legacy MMA conversion
// because LinearLayout seems to have some performance issues.
constexpr bool useLegacyMMAConversion = false;

struct ConvertLayoutOpConversion
: public ConvertOpToLLVMPattern<ConvertLayoutOp> {
public:
Expand Down Expand Up @@ -378,6 +382,9 @@ struct ConvertLayoutOpUsingLinearLayoutsConversion
/*accumNumReplicates=*/1)) {
return false;
}
if (useLegacyMMAConversion) {
return false;
}
return true;
}
if (isa<BlockedEncodingAttr>(layout)) {
Expand Down