[AMD][gfx12] Support emit indices logic WMMAv2 layout#4518
Merged
antiagainst merged 2 commits intotriton-lang:mainfrom Aug 27, 2024
Merged
[AMD][gfx12] Support emit indices logic WMMAv2 layout#4518antiagainst merged 2 commits intotriton-lang:mainfrom
antiagainst merged 2 commits intotriton-lang:mainfrom
Conversation
Contributor
joviliast
commented
Aug 14, 2024
joviliast
commented
- Supported linear layout for the 2nd version of WMMA
- Supported legacy emit indices related helper functions for now
- Removed remaining assertions related to WMMAv2
antiagainst
requested changes
Aug 15, 2024
| } | ||
| }; | ||
|
|
||
| LinearLayout tileLayout(initLinearLayout(wmma.getVersion())); |
Member
There was a problem hiding this comment.
Using a functor to intialize seems an overkill to me.
| {outDimNames[order[0]], outDimNames[order[1]]}); | ||
| case 2: | ||
| return LinearLayout( | ||
| {{kRegister, {/*gap*/ {0, 1}, {0, 2}, {0, 4}}}, |
| auto initLinearLayout = [&](int version) { | ||
| // For wmma with 16x16 output, each of the 32 threads holds 8 elements. | ||
| // | ||
| // For the register (i.e., element) dimension, these 8 elements are |
Member
There was a problem hiding this comment.
Don't we need to update this description for version 2?
joviliast
force-pushed
the
wmma2-linear-layout
branch
from
a19fd48 to
6a52036
Compare
- Supported linear layout for the 2nd version of WMMA - Supported legacy emit indices related helper functions for now - Removed remaining assertions related to WMMAv2 Signed-off-by: Ilya Veselov <iveselov.nn@gmail.com>
antiagainst
approved these changes
Aug 27, 2024
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
- Supported linear layout for the 2nd version of WMMA - Supported legacy emit indices related helper functions for now - Removed remaining assertions related to WMMAv2 Signed-off-by: Ilya Veselov <iveselov.nn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.