[AMD] Support FP8E5M2 with MFMA FP16 instructions#4259
Merged
antiagainst merged 4 commits intotriton-lang:mainfrom Aug 24, 2024
Merged
[AMD] Support FP8E5M2 with MFMA FP16 instructions#4259antiagainst merged 4 commits intotriton-lang:mainfrom
antiagainst merged 4 commits intotriton-lang:mainfrom
Conversation
Contributor
Cast dot arguments from unsupported FP8 to supported FP16 in order to use MFMA instructions instead of FMA. This approach is expected to give better performance and be more stable compared to FMA implementation.
antiagainst
approved these changes
Aug 24, 2024
antiagainst
requested review from
Jokeren,
ptillet and
zhanglx13
as code owners
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
Cast dot arguments from unsupported FP8 to supported FP16 in order to use MFMA instructions instead of FMA. This approach is expected to give better performance and be more stable compared to FMA implementation. --------- Co-authored-by: Lei Zhang <antiagainst@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cast dot arguments from unsupported FP8 to supported FP16 in order to use MFMA instructions instead of FMA.
This approach is expected to give better performance and be more stable compared to FMA implementation.