Skip to content

[BACKEND] Update LLVM version to llvm/llvm-project@4713bd4#4252

Merged
ThomasRaoux merged 1 commit intotriton-lang:mainfrom
openxla:llvm-4713bd4ccc0c0d568f92916e7851d993291742c0
Jul 19, 2024
Merged

[BACKEND] Update LLVM version to llvm/llvm-project@4713bd4#4252
ThomasRaoux merged 1 commit intotriton-lang:mainfrom
openxla:llvm-4713bd4ccc0c0d568f92916e7851d993291742c0

Conversation

@khasanovaa
Copy link
Copy Markdown
Contributor

@khasanovaa khasanovaa commented Jul 3, 2024 •
edited
Loading

This PR includes fixes from #4212 and updates llvm version to a newer.

@khasanovaa khasanovaa requested a review from ptillet as a code owner July 3, 2024 14:27
@gflegar gflegar force-pushed the llvm-4713bd4ccc0c0d568f92916e7851d993291742c0 branch from 3ffa8d4 to 357b77c Compare July 19, 2024 11:33
@gflegar gflegar marked this pull request as draft July 19, 2024 11:36
@gflegar gflegar marked this pull request as ready for review July 19, 2024 15:10
@gflegar
Copy link
Copy Markdown
Collaborator

gflegar commented Jul 19, 2024

@ThomasRaoux seems like this version is also good. (And the next one even fails to build LLVM on MacOs ARM.)

@ThomasRaoux
Copy link
Copy Markdown
Collaborator

ThomasRaoux commented Jul 19, 2024

@ThomasRaoux seems like this version is also good. (And the next one even fails to build LLVM on MacOs ARM.)

oh weird, I had not seen this issue yet. Do you have a link to the CI log? I don't see other PRs

@ThomasRaoux
Copy link
Copy Markdown
Collaborator

ThomasRaoux commented Jul 19, 2024

ah never mind others don't even build LLVM :( Weird I thought it worked on the later one

ThomasRaoux
ThomasRaoux approved these changes Jul 19, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this for now

@ThomasRaoux ThomasRaoux merged commit 915b396 into triton-lang:main Jul 19, 2024
@gflegar
Copy link
Copy Markdown
Collaborator

gflegar commented Jul 22, 2024

@ThomasRaoux seems like this version is also good. (And the next one even fails to build LLVM on MacOs ARM.)

oh weird, I had not seen this issue yet. Do you have a link to the CI log? I don't see other PRs

I didn't create them then yet, since they would anyway fail before we had the LLVM version built for them. Just created #4366, which is the one where MacOS ARM is failing. I re-triggered the job for non-ARM Ubuntu on it, since that's what integration tests are using. This way we at least see if we reproduce the failing tests we have on the newer LLVM version.

@gflegar gflegar deleted the llvm-4713bd4ccc0c0d568f92916e7851d993291742c0 branch July 22, 2024 08:47
@jlebar jlebar mentioned this pull request Sep 3, 2024
Merged
bertmaher pushed a commit to bertmaher/triton that referenced this pull request Dec 10, 2024
@khasanovaa @bertmaher
[BACKEND] Update LLVM version to llvm/llvm-project@4713bd4 (triton-la…
fc666a1 
…ng#4252)

This PR includes fixes from
triton-lang#4212 and updates llvm version
to a newer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomasRaoux ThomasRaoux ThomasRaoux approved these changes

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khasanovaa @gflegar @ThomasRaoux