Pass repr=key when calling JITFunction.cache_hook#4207
Closed
Conversation
Before this PR, we had two key-like strings for JITFunctions. - key: Guaranteed unique per compiled kernel, suitable for caching. - repr: Not guaranteed-unique, missing some fields (for example, can't distinguish between fp32 and fp16 params), but perhaps more human-readable than `key`? This PR removes repr and replaces it with key, thus removing a footgun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, we had two key-like strings for JITFunctions.
distinguish between fp32 and fp16 params), but perhaps more human-readable
than
key?This PR removes repr and replaces it with key, thus removing a footgun.