Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions test/Conversion/amd/amd-convert-builtin-func.mlir
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
// RUN: triton-opt --convert-builtin-func-to-llvm %s | FileCheck %s

// Trying to merge those blocks will cause a lot of duplication in the block arguments, which will cause
// an exponential growth of the argument length. Make sure we don't try to merge those blocks.
module {
llvm.func @rand() -> i1
llvm.func @"__predicated_store_!llvm.void_!llvm.ptr<1>_i32_i1_"(!llvm.ptr<1>, i32, i1) attributes {libname = "", libpath = ""}

llvm.func @top(%arg0: i64, %1 : !llvm.ptr<1>, %2 : !llvm.ptr<1>, %3 : !llvm.ptr<1>, %4 : !llvm.ptr<1>) {
%0 = llvm.mlir.constant(0 : i64) : i64
%10 = llvm.icmp "eq" %arg0, %0 : i64
%true = llvm.mlir.constant(1 : i1) : i1
%c = llvm.mlir.constant(1 : i32) : i32
// CHECK: llvm.cond_br {{.*}}, ^bb{{.*}}, ^bb{{.*}}
llvm.cond_br %10, ^bb1, ^bb14
^bb1: // pred: ^bb0
%11 = llvm.call @rand() : () -> i1
// CHECK: llvm.cond_br {{.*}}, ^bb{{.*}}, ^bb{{.*}}
llvm.cond_br %11, ^bb2, ^bb3
^bb2: // pred: ^bb1
llvm.call @"__predicated_store_!llvm.void_!llvm.ptr<1>_i32_i1_"(%1, %c, %true) : (!llvm.ptr<1>, i32, i1) -> ()
llvm.br ^bb4
^bb3: // pred: ^bb1
llvm.call @"__predicated_store_!llvm.void_!llvm.ptr<1>_i32_i1_"(%2, %c, %true) : (!llvm.ptr<1>, i32, i1) -> ()
llvm.br ^bb4
^bb4: // 2 preds: ^bb2, ^bb3
%14 = llvm.call @rand() : () -> i1
// CHECK: llvm.cond_br {{.*}}, ^bb{{.*}}, ^bb{{.*}}
llvm.cond_br %14, ^bb5, ^bb6
^bb5: // pred: ^bb4
llvm.call @"__predicated_store_!llvm.void_!llvm.ptr<1>_i32_i1_"(%3, %c, %true) : (!llvm.ptr<1>, i32, i1) -> ()
llvm.br ^bb13
^bb6: // pred: ^bb4
llvm.call @"__predicated_store_!llvm.void_!llvm.ptr<1>_i32_i1_"(%4, %c, %true) : (!llvm.ptr<1>, i32, i1) -> ()
llvm.br ^bb13
^bb13: // 2 preds: ^bb11, ^bb12
llvm.br ^bb27
^bb14: // pred: ^bb0
%23 = llvm.call @rand() : () -> i1
// CHECK: llvm.cond_br {{.*}}, ^bb{{.*}}, ^bb{{.*}}
llvm.cond_br %23, ^bb15, ^bb16
^bb15: // pred: ^bb14
llvm.call @"__predicated_store_!llvm.void_!llvm.ptr<1>_i32_i1_"(%4, %c, %true) : (!llvm.ptr<1>, i32, i1) -> ()
llvm.br ^bb17
^bb16: // pred: ^bb14
llvm.call @"__predicated_store_!llvm.void_!llvm.ptr<1>_i32_i1_"(%3, %c, %true) : (!llvm.ptr<1>, i32, i1) -> ()
llvm.br ^bb17
^bb17: // 2 preds: ^bb15, ^bb16
%26 = llvm.call @rand() : () -> i1
// CHECK: llvm.cond_br {{.*}}, ^bb{{.*}}, ^bb{{.*}}
llvm.cond_br %26, ^bb18, ^bb19
^bb18: // pred: ^bb17
llvm.call @"__predicated_store_!llvm.void_!llvm.ptr<1>_i32_i1_"(%2, %c, %true) : (!llvm.ptr<1>, i32, i1) -> ()
llvm.br ^bb26
^bb19: // pred: ^bb17
llvm.call @"__predicated_store_!llvm.void_!llvm.ptr<1>_i32_i1_"(%1, %c, %true) : (!llvm.ptr<1>, i32, i1) -> ()
llvm.br ^bb26
^bb26: // 2 preds: ^bb24, ^bb25
llvm.br ^bb27
^bb27: // 2 preds: ^bb13, ^bb26
llvm.return
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,17 @@ struct ConvertBuiltinFuncToLLVM
MLIRContext *context = &getContext();
ModuleOp mod = getOperation();

// Disable block merging because of:
// https://github.com/llvm/llvm-project/issues/63230
// TODO(giuseros): enable block merging once the above ticket is completed
GreedyRewriteConfig config;
config.enableRegionSimplification = GreedySimplifyRegionLevel::Normal;

RewritePatternSet patterns(context);
patterns.add<CallOpConversion>(context);

if (mlir::applyPatternsAndFoldGreedily(mod, std::move(patterns)).failed()) {
if (mlir::applyPatternsAndFoldGreedily(mod, std::move(patterns), config)
.failed()) {
signalPassFailure();
}
}
Expand Down