Skip to content

[BACKEND] Fix workaround for unsupported cases in maybeDeduplicate #4048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasRaoux merged 1 commit into from
May 31, 2024
Merged

[BACKEND] Fix workaround for unsupported cases in maybeDeduplicate #4048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions include/triton/Conversion/TritonGPUToLLVM/ElementwiseOpToLLVMBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,12 @@ class ElementwiseOpConversionBase : public ConvertOpToLLVMPattern<SourceOp> {
if (!encoding)
// encoding not available
return resultVals;
if (!dyn_cast<BlockedEncodingAttr>(encoding) &&
!dyn_cast<SliceEncodingAttr>(encoding)) {
// TODO: constraining the ecndoing type here is necessary for avoiding
// crashes in the getElemsPerThread call below happening in the
Attribute baseEncoding = encoding;
while (auto sliced = dyn_cast<SliceEncodingAttr>(baseEncoding))
baseEncoding = sliced.getParent();
if (isa<NvidiaMmaEncodingAttr, DotOperandEncodingAttr>(baseEncoding)) {
// TODO: this logic seems incorrect for mma layout. Skip for now.
// The following test crashes and some other miscompile:
// test_core::test_fp8_dot_acc
return resultVals;
}
Expand Down