Repository navigation
[CI] Rename check_cuda_only() to check_cuda_or_hip(). - #3946
Merged
Merged
Conversation
jlebar
changed the title
Contributor
|
Ah, I'm afraid it may have to do with Intel devices? @whitneywhtsang |
Contributor
Collaborator
|
yes I assume this will break downstream backends? |
Contributor
Author
|
I see, this was indeed added in a3c39d8 by someone with an I'll rewrite the PR from |
This matches the behavior of the function.
jlebar
changed the title
Contributor
Author
|
OK, I have updated this PR to be a simple rename. |
ThomasRaoux
approved these changes
May 20, 2024
antiagainst
approved these changes
May 20, 2024
antiagainst
left a comment
antiagainst
left a comment
Member
There was a problem hiding this comment.
Yeah. It's a bit confusing that cuda can mean both in pytorch.. thanks for making this clear!
Jokeren
approved these changes
May 20, 2024
whitneywhtsang
left a comment
whitneywhtsang
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for making the code more readable!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the behavior of the function.