[FRONTEND] Add support for using remote cache managers#2934
Merged
jansel merged 2 commits intotriton-lang:mainfrom Mar 4, 2024
Merged
[FRONTEND] Add support for using remote cache managers#2934jansel merged 2 commits intotriton-lang:mainfrom
jansel merged 2 commits intotriton-lang:mainfrom
Conversation
andrewjcg
force-pushed
the
remote_cache
branch
from
36f58c3 to
4601cbb
Compare
ptillet
reviewed
Jan 15, 2024
|
|
||
| from .cache import RemoteCacheBackend | ||
|
|
||
| import redis |
Collaborator
There was a problem hiding this comment.
can we import this lazily so we Triton doesn't have to depend on redis?
That said, i guess no other file imports redis.py so maybe it's fine?
Contributor
Author
There was a problem hiding this comment.
Ah yeah, I was wondering this at the time. I think the only way this file would get loaded is if the user sets e.g. TRITON_CACHE_MANAGER=triton.runtime.cache:RemoteCacheManager TRITON_REMOTE_CACHE_BACKEND=triton.runtime.redis:RedisRemoteCacheBackend, but I didn't know if there was potentially some other setup that was sensitive to top-level imports even the module itself isn't explicitly loaded.
Collaborator
There was a problem hiding this comment.
I think that's fair, but I believe it may be even cleaner to move import redis inside of RedisRemoteCacheBackend.__init__ and define RedisRemoteCacheBackend in cache.py
Contributor
Author
There was a problem hiding this comment.
Updated to do this.
andrewjcg
force-pushed
the
remote_cache
branch
from
4601cbb to
2414638
Compare
ptillet
approved these changes
Jan 16, 2024
andrewjcg
force-pushed
the
remote_cache
branch
4 times, most recently
from
a8624ef to
8fc71ec
Compare
Contributor
|
@andrewjcg are we planning on merging this? |
Contributor
|
@andrewjcg @oulgen looks like a lint is failing: |
Adds a redis-based one as an initial implementation, but it should be straightforward to extend with more impls.
auto-merge was automatically disabled
March 4, 2024 21:34
Head branch was pushed to by a user without write access
pawelszczerbuk
added a commit
that referenced
this pull request
Mar 11, 2024
…terface method (#3336) #2934 have changed some of the FileCacheManager methods into a private interface, while `_has_file` method is still being used by the Override functionality. Exposing the method again. (An alternative is to call private `_has_file` from the override, which would be OK too, since it is debug only thing).
shunting314
added a commit
to shunting314/triton
that referenced
this pull request
Mar 19, 2024
…nagers (triton-lang#2934) (triton-lang#3379)" This reverts commit 996b6c0.
htyu
pushed a commit
to htyu/triton
that referenced
this pull request
Mar 20, 2024
…riton-lang#3302) triton-lang#2934 added `RedisRemoteCacheBackend` but did not add the symbol to `__init__.py`. Let's also add there so that we can refer to it via full path instead of having to `from ... import RedisRemoteCacheBackend`.
htyu
pushed a commit
to htyu/triton
that referenced
this pull request
Mar 20, 2024
…terface method (triton-lang#3336) triton-lang#2934 have changed some of the FileCacheManager methods into a private interface, while `_has_file` method is still being used by the Override functionality. Exposing the method again. (An alternative is to call private `_has_file` from the override, which would be OK too, since it is debug only thing).
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
…riton-lang#2934) (triton-lang#3379) Adds a redis-based one as an initial implementation, but it should be straightforward to extend with more impls. Co-authored-by: andrewjcg <andrewjcg@gmail.com>
binarman
pushed a commit
to binarman/triton
that referenced
this pull request
Apr 2, 2024
…riton-lang#3302) triton-lang#2934 added `RedisRemoteCacheBackend` but did not add the symbol to `__init__.py`. Let's also add there so that we can refer to it via full path instead of having to `from ... import RedisRemoteCacheBackend`.
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
…terface method (triton-lang#3336) triton-lang#2934 have changed some of the FileCacheManager methods into a private interface, while `_has_file` method is still being used by the Override functionality. Exposing the method again. (An alternative is to call private `_has_file` from the override, which would be OK too, since it is debug only thing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a redis-based one as an initial implementation, but it should be straightforward to extend with more impls.