Windows build fix #2738

wkpark · 2023-12-01T22:40:12Z

based on #2465

manually applied, rebased, fix lint errors
use set_target_properties(), cleanup for windows
remove '/A' platform option to use windows ninja, remove unknown option '/m'
use sysconfig.get_config_var() to get the path of python*.lib
use os.name to check dll extension
clang fix for windows
remove '-fPIC' for windows clang

support both clang and msvc

See also (with workflows fixes)

~~clang build cp311: https://github.com/wkpark/triton/actions/runs/7065823185~~
~~msvc build cp311: https://github.com/wkpark/triton/actions/runs/7070390905~~
ubuntu clang, windows msvc builds - cp310, cp311: ~~https://github.com/wkpark/triton/actions/runs/7077852509~~
~~https://github.com/wkpark/triton/actions/runs/7081762873~~
~~https://github.com/wkpark/triton/actions/runs/7245060800 (2023/12/18)~~
~~https://github.com/wkpark/triton/actions/runs/7246431088 windows clang builds (2023/12/18)~~
https://github.com/wkpark/triton/actions/runs/7623880319 (2024/01/23)

(login github, scroll down the page, then you can download compiled windows artifacts)

ptillet · 2023-12-02T00:46:05Z

I think python/triton/common/build.py is becoming way too complicated. It would be great to have abstractions instead of another if/else statement

wkpark · 2023-12-02T12:59:02Z

I think python/triton/common/build.py is becoming way too complicated. It would be great to have abstractions instead of another if/else statement

I don't think it's gotten too complicated, but I've tried to clean up _build() a bit.

wkpark · 2023-12-03T05:35:37Z

rebased, partially squashed

wkpark · 2023-12-03T15:30:22Z

now runtime tests are passed with minor fixes

test_subproc.py needs "spawn"
test_cache.py with tempfile.NamedTemporaryFile(mode='w+', suffix='.py', delete=False)

(venv) D:\src\triton\python\test\unit>python -m pytest runtime
======================================================= test session starts =======================================================
platform win32 -- Python 3.10.11, pytest-7.4.2, pluggy-1.3.0
rootdir: D:\src\triton\python
plugins: anyio-3.7.1, hydra-core-1.3.2, xdist-3.5.0
collected 21 items

runtime\test_autotuner.py ....                                                                                               [ 19%]
runtime\test_cache.py .............                                                                                          [ 80%]
runtime\test_driver.py .                                                                                                     [ 85%]
runtime\test_launch.py .                                                                                                     [ 90%]
runtime\test_subproc.py ..                                                                                                   [100%]

======================================================= 21 passed in 25.69s =======================================================

If you prefer to clean up commits to reduce the number, I'll do a partial squash, so let me know.

FurkanGozukara · 2023-12-05T00:31:39Z

thank you so much
so currently any pip install link for python 3.10.x?

wkpark · 2023-12-05T01:17:17Z

thank you so much so currently any pip install link for python 3.10.x?

a direct pip link is not available yet but downloadable artifacts are available (working on next workflows PR)
https://github.com/wkpark/triton/actions/runs/7091492250 (github login required. scroll down and you can find downloadable links)

wkpark · 2023-12-05T06:35:38Z

rebased

FurkanGozukara · 2023-12-05T10:19:43Z

thank you so much so currently any pip install link for python 3.10.x?

a direct pip link is not available yet but downloadable artifacts are available (working on next workflows PR) https://github.com/wkpark/triton/actions/runs/7091492250 (github login required. scroll down and you can find downloadable links)

thank you so much. i am waiting direct pip link hopefully

wkpark · 2023-12-08T07:33:38Z

rebased, conflict resolved.

FurkanGozukara · 2023-12-08T10:45:56Z

amazing still waiting direct pip install

FurkanGozukara · 2023-12-17T19:16:42Z

awesome more fix. any pip install link so far?

wkpark · 2023-12-17T19:18:06Z

just rebased, resolve conflicts

wkpark · 2023-12-17T19:30:47Z

~~https://github.com/wkpark/triton/actions/runs/7097090430~~
https://github.com/wkpark/triton/actions/runs/7081762873

If anyone interested in this PR
follow the above link, download the wheel file at the bottom of the page (github login required), install the wheel on your Windows system, and leave your results here to help the developers. (using pip install command...)

If you have a little more time on your hands, you might want to try running a pytest in the directory under python/test/unit after cloning the triton repo., and report back here with your results.

techcto · 2023-12-18T01:11:07Z

https://github.com/wkpark/triton/actions/runs/7097090430

If anyone interested in this PR follow the above link, download the wheel file at the bottom of the page (github login required), install the wheel on your Windows system, and leave your results here to help the developers. (using pip install command...)

If you have a little more time on your hands, you might want to try running a pytest in the directory under python/test/unit after cloning the triton repo., and report back here with your results.

Is there a Windows Python 311 to test?

FurkanGozukara · 2023-12-18T01:12:18Z

https://github.com/wkpark/triton/actions/runs/7097090430

If anyone interested in this PR follow the above link, download the wheel file at the bottom of the page (github login required), install the wheel on your Windows system, and leave your results here to help the developers. (using pip install command...)

If you have a little more time on your hands, you might want to try running a pytest in the directory under python/test/unit after cloning the triton repo., and report back here with your results.

it is only python 3.9 i think is that accurate?

wkpark · 2024-01-23T11:24:21Z

rebased with minor fix.
https://github.com/wkpark/triton/actions/runs/7623880319 (latest triton builds)

FurkanGozukara · 2024-01-23T12:53:18Z

rebased with minor fix. https://github.com/wkpark/triton/actions/runs/7623880319 (latest triton builds)

awesome ty

wkpark · 2024-02-10T14:11:24Z

rebased, conflict resolved.
~~build wheels will be available soon.~~

https://github.com/wkpark/triton/actions/runs/7855606361

how to test?

install the prebuilt wheel from https://github.com/wkpark/triton/actions/runs/7855606361 (github login required. you can find Windows wheel at the bottom of the page)
clone triton repo: https://github.com/openai/triton
open visual studio 2022 cmd prompt.
check cl command. set CC and CXX env. (set CC=cl and set CXX=cl in the cmd prompt)
cd python\test\unit
python -m pytest -s runtime

see also #2738 (comment)

* based on triton-lang#2465 * manually applied, rebased, fix lint errors * use set_target_properties(), cleanup for windows * remove '/A' platform option to use windows ninja * remove unknown option '/m' * use sysconfig.get_config_var() to get the path of python*.lib * clang fix for windows * remove '-fPIC' for windows clang * fix download_and_copy() to support windows * add "exe" extension for windows * use "pyd" extension for windows to make importlib work * rework for latest triton (2024/01/14) Original-author-by: Andrei Gheorghe <[email protected]> Signed-off-by: Won-Kyu Park <[email protected]>

@andreigh

* based on Windows support PR triton-lang#2456 by @andreigh * WIN32 fix using LoadLibrary

clang error "(aka 'long long') must match previous return type 'long' when lambda expression has unspecified explicit return typ"

* win32 fix _path_to_binary() * add library_dir, include_dir for win32

FurkanGozukara · 2024-02-10T15:23:25Z

@wkpark any new link of downloading newest push pre compiled wheel?

ptillet · 2024-03-09T21:46:05Z

Sorry, but I will unfortunately close this. I don't think we have the bandwidth to commit to supporting windows upstream. Maybe this can be done in a fork for now?

biship · 2024-03-09T21:55:41Z

Yeah no one uses Windows.

FurkanGozukara · 2024-03-09T23:47:36Z

Windows is most commonly used OS what are you dreaming?

dgoryeo · 2024-03-10T03:16:31Z

Haha, I think it was meant to be sarcastic :)

What is mind-boggling to me is that openai does not support the OS platform of their largest investor that has given them $13 billion so far. I really wonder ...

FurkanGozukara · 2024-03-10T04:07:12Z

Haha, I think it was meant to be sarcastic :)

What is mind-boggling to me is that openai does not support the OS platform of their largest investor that has given them $13 billion so far. I really wonder ...

100%

I complained about this too

wkpark · 2024-03-10T10:05:16Z

Sorry, but I will unfortunately close this. I don't think we have the bandwidth to commit to supporting windows upstream. Maybe this can be done in a fork for now?

no problem, I can understand. that ways opensource goes. but I'm not consider any fork. instead I will try to extract some part of mergeable hunks, for example, clang for windows work perfectly. we don't have to support MSVC, instead we can make clang compatible code for both windows and linux in mind. etc.
thank you for this great project and thank you for your concern!

showkeyjar · 2024-04-21T08:22:12Z

@wkpark how to use your "llvm-4017f04e-windows-x64" release? compile it?

FurkanGozukara · 2024-07-26T01:24:04Z

please return back publishing @wkpark

we need you : THUDM/CogVLM2#169

wkpark requested a review from ptillet as a code owner December 1, 2023 22:40

wkpark force-pushed the windows-fix branch from da045b3 to 5f07810 Compare December 1, 2023 22:43

wkpark force-pushed the windows-fix branch 2 times, most recently from 85916b4 to edbfb14 Compare December 2, 2023 12:58

This was referenced Dec 2, 2023

Compilation problems on windows 11 #1560

Open

Is Triton unable to install in python 3.10 versions? #1057

Open

wkpark force-pushed the windows-fix branch from edbfb14 to 57084c1 Compare December 3, 2023 05:34

wkpark force-pushed the windows-fix branch 2 times, most recently from becd537 to 6b3c9c6 Compare December 3, 2023 11:00

wkpark force-pushed the windows-fix branch 2 times, most recently from 5290766 to 7147517 Compare December 4, 2023 08:41

wkpark force-pushed the windows-fix branch from 7147517 to 360bc75 Compare December 5, 2023 06:28

wkpark force-pushed the windows-fix branch from 360bc75 to eb7f3c6 Compare December 5, 2023 10:08

wkpark force-pushed the windows-fix branch from eb7f3c6 to 4f0981d Compare December 8, 2023 07:28

wkpark force-pushed the windows-fix branch from d669732 to 0b636d9 Compare December 17, 2023 19:14

wkpark force-pushed the windows-fix branch 2 times, most recently from 2c5a8ee to 20d41c4 Compare January 23, 2024 09:07

FurkanGozukara mentioned this pull request Jan 24, 2024

It starts, but the console displays some errors Nerogar/OneTrainer#134

Closed

wkpark force-pushed the windows-fix branch from 20d41c4 to 6181843 Compare February 10, 2024 14:08

wkpark added 8 commits February 10, 2024 23:44

dlopen fix for win32

81e5e0d

* based on Windows support PR triton-lang#2456 by @andreigh * WIN32 fix using LoadLibrary

fix compile error

4bfde78

clang error "(aka 'long long') must match previous return type 'long' when lambda expression has unspecified explicit return typ"

unit/runtime/*.py fix for windows

91fe154

call subprocess.run() without shell option

616463f

third_party/nvidia: fix for windows

d279ef6

* win32 fix _path_to_binary() * add library_dir, include_dir for win32

fix compile error

2465e8d

disable amd for win32

50bbd49

wkpark force-pushed the windows-fix branch from 6181843 to 50bbd49 Compare February 10, 2024 14:45

Merge branch 'main' into windows-fix

c1878dc

ptillet closed this Mar 9, 2024

mantaionut mentioned this pull request Jun 7, 2024

Windows support #4045

Closed

6 tasks

nieznanysprawiciel mentioned this pull request Jun 14, 2024

Investigate problems with VLLM running on windows golemfactory/gamerhash-facade#151

Closed

FurkanGozukara mentioned this pull request Jul 26, 2024

With billion dollars you still don't support Windows and thus we can't use CogVLM V2 on Windows! #4395

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows build fix #2738

Windows build fix #2738

wkpark commented Dec 1, 2023 •

edited

Loading

ptillet commented Dec 2, 2023

wkpark commented Dec 2, 2023

wkpark commented Dec 3, 2023

wkpark commented Dec 3, 2023

FurkanGozukara commented Dec 5, 2023

wkpark commented Dec 5, 2023 •

edited

Loading

wkpark commented Dec 5, 2023

FurkanGozukara commented Dec 5, 2023

wkpark commented Dec 8, 2023

FurkanGozukara commented Dec 8, 2023

FurkanGozukara commented Dec 17, 2023

wkpark commented Dec 17, 2023

wkpark commented Dec 17, 2023 •

edited

Loading

techcto commented Dec 18, 2023

FurkanGozukara commented Dec 18, 2023

wkpark commented Jan 23, 2024

FurkanGozukara commented Jan 23, 2024

wkpark commented Feb 10, 2024 •

edited

Loading

FurkanGozukara commented Feb 10, 2024

ptillet commented Mar 9, 2024

biship commented Mar 9, 2024

FurkanGozukara commented Mar 9, 2024

dgoryeo commented Mar 10, 2024

FurkanGozukara commented Mar 10, 2024

wkpark commented Mar 10, 2024 •

edited

Loading

showkeyjar commented Apr 21, 2024

FurkanGozukara commented Jul 26, 2024

Windows build fix #2738

Windows build fix #2738

Conversation

wkpark commented Dec 1, 2023 • edited Loading

ptillet commented Dec 2, 2023

wkpark commented Dec 2, 2023

wkpark commented Dec 3, 2023

wkpark commented Dec 3, 2023

FurkanGozukara commented Dec 5, 2023

wkpark commented Dec 5, 2023 • edited Loading

wkpark commented Dec 5, 2023

FurkanGozukara commented Dec 5, 2023

wkpark commented Dec 8, 2023

FurkanGozukara commented Dec 8, 2023

FurkanGozukara commented Dec 17, 2023

wkpark commented Dec 17, 2023

wkpark commented Dec 17, 2023 • edited Loading

techcto commented Dec 18, 2023

FurkanGozukara commented Dec 18, 2023

wkpark commented Jan 23, 2024

FurkanGozukara commented Jan 23, 2024

wkpark commented Feb 10, 2024 • edited Loading

how to test?

FurkanGozukara commented Feb 10, 2024

ptillet commented Mar 9, 2024

biship commented Mar 9, 2024

FurkanGozukara commented Mar 9, 2024

dgoryeo commented Mar 10, 2024

FurkanGozukara commented Mar 10, 2024

wkpark commented Mar 10, 2024 • edited Loading

showkeyjar commented Apr 21, 2024

FurkanGozukara commented Jul 26, 2024

wkpark commented Dec 1, 2023 •

edited

Loading

wkpark commented Dec 5, 2023 •

edited

Loading

wkpark commented Dec 17, 2023 •

edited

Loading

wkpark commented Feb 10, 2024 •

edited

Loading

wkpark commented Mar 10, 2024 •

edited

Loading