Skip to content

[ANALYSIS] Fix AxisInfoAnalysis for arith.select #2711

Merged
ptillet merged 3 commits intotriton-lang:mainfrom
Jokeren:keren/fix-select
Nov 28, 2023
Merged

[ANALYSIS] Fix AxisInfoAnalysis for arith.select #2711
ptillet merged 3 commits intotriton-lang:mainfrom
Jokeren:keren/fix-select

Conversation

@Jokeren
Copy link
Copy Markdown
Contributor

@Jokeren Jokeren commented Nov 28, 2023 •
edited
Loading

  1. Fix a segment fault when the condition is i1.
  2. Fix the divisibility calculation when contiguity has been changed (different than cond, lhs, or rhs).

@Jokeren Jokeren requested a review from ptillet as a code owner November 28, 2023 16:01
@manman-ren
Copy link
Copy Markdown
Collaborator

manman-ren commented Nov 28, 2023

Seems to have lit failure on H100:
Failed Tests (1):
TRITON :: Analysis/test-alignment.mlir

@Jokeren Jokeren changed the title [ANALYSIS] Fix AxisInfoAnalysis for arith.select with i1 condition [ANALYSIS] Fix AxisInfoAnalysis for arith.select Nov 28, 2023
ThomasRaoux
ThomasRaoux approved these changes Nov 28, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ptillet ptillet merged commit bfb9c23 into triton-lang:main Nov 28, 2023
@Jokeren Jokeren deleted the keren/fix-select branch December 7, 2023 23:52
feihugis pushed a commit to feihugis/triton that referenced this pull request Feb 13, 2024
@Jokeren
[ANALYSIS] Fix AxisInfoAnalysis for arith.select (triton-lang#2711)
d02fd74 
1. Fix a segment fault when the condition is `i1`.
2. Fix the divisibility calculation when contiguity has been changed
(different than cond, lhs, or rhs).
pingzhuu pushed a commit to siliconflow/triton that referenced this pull request Apr 2, 2024
@Jokeren
[ANALYSIS] Fix AxisInfoAnalysis for arith.select (triton-lang#2711)
885db75 
1. Fix a segment fault when the condition is `i1`.
2. Fix the divisibility calculation when contiguity has been changed
(different than cond, lhs, or rhs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptillet ptillet ptillet approved these changes

@ThomasRaoux ThomasRaoux ThomasRaoux approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jokeren @manman-ren @ptillet @ThomasRaoux