[FRONTEND] Emit warnings via native Python C API rather than py::exec() calls#2703
Merged
Conversation
Jokeren
approved these changes
Nov 27, 2023
feihugis
pushed a commit
to feihugis/triton
that referenced
this pull request
Feb 13, 2024
…c()` calls (triton-lang#2703) This PR replaces the `py::exec()` calls with native Python C API. This is much safer and eliminates the side effects on the Python side (e.g., assignment for function `warnings.showwarning`). Ref: - triton-lang#2155
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
…c()` calls (triton-lang#2703) This PR replaces the `py::exec()` calls with native Python C API. This is much safer and eliminates the side effects on the Python side (e.g., assignment for function `warnings.showwarning`). Ref: - triton-lang#2155
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
py::exec()calls with native Python C API. This is much safer and eliminates the side effects on the Python side (e.g., assignment for functionwarnings.showwarning).Ref:
tl.advanceis unused #2155