Skip to content

[BACKEND] Refactor the TritonGPU dialect utils to call the APIs of the TritonGPU layout attributes. #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasRaoux merged 2 commits into from
Nov 29, 2023
Merged

[BACKEND] Refactor the TritonGPU dialect utils to call the APIs of the TritonGPU layout attributes. #2682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3912fdb
[BACKEND] Refactor the TritonGPU dialect utils to call the APIs of th…
chengjunlu Nov 20, 2023
efa0ddb
Merge branch 'main' into chengjun/tritongpu_refactor
chengjunlu Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions include/triton/Dialect/TritonGPU/IR/Dialect.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ getThreadsPerWarpWithUniqueData(Attribute layout,
SmallVector<unsigned>
getWarpsPerCTAWithUniqueData(Attribute layout, ArrayRef<int64_t> tensorShape);

SmallVector<unsigned> getThreadsPerCTA(Attribute layout);

SmallVector<unsigned> getOrder(Attribute layout);

CTALayoutAttr getCTALayout(Attribute layout);
Expand Down
6 changes: 2 additions & 4 deletions lib/Analysis/Utility.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,8 @@ bool ReduceOpHelper::isSupportedLayout() {
if (srcLayout.isa<triton::gpu::BlockedEncodingAttr>()) {
return true;
}
if (auto mmaLayout = srcLayout.dyn_cast<triton::gpu::MmaEncodingAttr>()) {
if (mmaLayout.isAmpere() || mmaLayout.isHopper()) {
return true;
}
if (auto mmaLayout = srcLayout.dyn_cast<triton::gpu::MmaEncodingTrait>()) {
return mmaLayout.supportReduction();
}
if (auto sliceLayout = srcLayout.dyn_cast<triton::gpu::SliceEncodingAttr>()) {
return true;
Expand Down
Loading