Bump LLVM version to 5e5a22ca#2608
Merged
ThomasRaoux merged 13 commits intomainfrom Nov 29, 2023
Merged
Conversation
karupayun
changed the title
karupayun
force-pushed
the
llvm-head
branch
3 times, most recently
from
1d596a0 to
b68d6ba
Compare
karupayun
force-pushed
the
llvm-head
branch
2 times, most recently
from
bd51fad to
d198918
Compare
vwbaker
force-pushed
the
llvm-head
branch
2 times, most recently
from
6ce30b5 to
e3fd11a
Compare
This patch adds a text file that holds the LLVM commit hash to be used with the Triton code. Once the workflow files are added to the main branch, any updates to this text file in the llvm-head branch will trigger an LLVM build and the corresponding build artifacts will be uploaded to Azure Blob storage. Squashed commits: Bump LLVM version. Update LLVM version to llvm/llvm-project@0954dc3 update hash to 76ce4736721a update llvm hash: b1115f8ccefb380824a9d997622cc84fc0d84a89 [ci] now set LLVM_BUILD_TOOLS=ON in llvm-build.yml
Include fixes for LLVM change 3cd2a0bc llvm/llvm-project@3cd2a0b
It's a preparation for llvm/llvm-project@4983432. SharedMemoryObject used to get type of the element type from typed pointer, but with the conversion to opaque pointers we need to have the element type stored explicitly. Asserts will removed once we fully migrate to opaque pointers. Right now they make sure that we're passing the correct element type.
Typed pointers are deprecated from MLIR LLVM dialect since llvm/llvm-project@4983432.
This should fix the error `write no space left on device` as suggested by ptillet on slack.
Without this change, some of the prints were giving the error: llvm.getelementptr' op type 'i8' cannot be indexed. In one case I removed an index into a 1D array and in another I changed the type to be a struct as that's the type it's indexing into.
Collaborator
|
Sorry this is such a big update - opaque pointers by llvm forced us to have a lot of changes. Everything should be working now though and it should be in a review-able state :) @ptillet |
Collaborator
|
Thank you! We will review |
ThomasRaoux
approved these changes
Nov 29, 2023
Collaborator
ThomasRaoux
left a comment
ThomasRaoux
left a comment
There was a problem hiding this comment.
Thanks for moving us to opaque pointers!
zoranjovanovic-ns
pushed a commit
to ROCm/triton
that referenced
this pull request
Jan 12, 2024
Include fixes for different LLVM updates, that includes: - Add elem type to SharedMemoryObject. - Change all pointers to opaque. - Fixes for llvm update 3cd2a0bc --------- Co-authored-by: Ashay Rane <ashay@users.noreply.github.com> Co-authored-by: Goran Flegar <gflegar@google.com> Co-authored-by: khasanovaa <khasanovaaliya19@gmail.com> Co-authored-by: Tori Baker <vwbaker@google.com> Co-authored-by: Aliia Khasanova <40315403+khasanovaa@users.noreply.github.com>
feihugis
pushed a commit
to feihugis/triton
that referenced
this pull request
Feb 13, 2024
Include fixes for different LLVM updates, that includes: - Add elem type to SharedMemoryObject. - Change all pointers to opaque. - Fixes for llvm update 3cd2a0bc --------- Co-authored-by: Ashay Rane <ashay@users.noreply.github.com> Co-authored-by: Goran Flegar <gflegar@google.com> Co-authored-by: khasanovaa <khasanovaaliya19@gmail.com> Co-authored-by: Tori Baker <vwbaker@google.com> Co-authored-by: Aliia Khasanova <40315403+khasanovaa@users.noreply.github.com>
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
Include fixes for different LLVM updates, that includes: - Add elem type to SharedMemoryObject. - Change all pointers to opaque. - Fixes for llvm update 3cd2a0bc --------- Co-authored-by: Ashay Rane <ashay@users.noreply.github.com> Co-authored-by: Goran Flegar <gflegar@google.com> Co-authored-by: khasanovaa <khasanovaaliya19@gmail.com> Co-authored-by: Tori Baker <vwbaker@google.com> Co-authored-by: Aliia Khasanova <40315403+khasanovaa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include fixes for different LLVM updates, that includes: