[BACKEND] Relax patterns to move sink broadcast and hoist convert#2331
Merged
[BACKEND] Relax patterns to move sink broadcast and hoist convert#2331
Conversation
Collaborator
Author
|
based on PR comments from @peterbell10 |
Improve patterns that sync broadcast to reduce the arithmetic density and also hoist convert on top of expand_dims to do less work. This address comments in #2274
ThomasRaoux
force-pushed
the
arith_reduction
branch
from
1b0753c to
4ccfbc7
Compare
|
|
ptillet
approved these changes
Sep 18, 2023
alexander-zinoviev
pushed a commit
to alexander-zinoviev/triton
that referenced
this pull request
Sep 21, 2023
…iton-lang#2331) Improve patterns that sync broadcast to reduce the arithmetic density and also hoist convert on top of expand_dims to do less work. This address comments in triton-lang#2274
binarman
added a commit
to binarman/triton
that referenced
this pull request
Oct 26, 2023
This PR fixes layout propagation algorithm in RemoveLayoutConversions pass. In some cases during rewriteSlice process, reduce operation with multiple outputs rewrites only one output layout, which breaks assumption that both outputs should have same layout. This change is a minimal part of triton-lang#2331 change and small lit test for regression testing.
alefimov-amd
pushed a commit
to binarman/triton
that referenced
this pull request
Oct 26, 2023
This PR fixes layout propagation algorithm in RemoveLayoutConversions pass. In some cases during rewriteSlice process, reduce operation with multiple outputs rewrites only one output layout, which breaks assumption that both outputs should have same layout. This change is a minimal part of triton-lang#2331 change and small lit test for regression testing.
binarman
added a commit
to binarman/triton
that referenced
this pull request
Oct 30, 2023
This PR fixes layout propagation algorithm in RemoveLayoutConversions pass. In some cases during rewriteSlice process, reduce operation with multiple outputs rewrites only one output layout, which breaks assumption that both outputs should have same layout. This change is a minimal part of triton-lang#2331 change and small lit test for regression testing.
zhanglx13
pushed a commit
to ROCm/triton
that referenced
this pull request
Nov 1, 2023
* [RemoveLayoutConversions] Fix reduce failed infer type error This PR fixes layout propagation algorithm in RemoveLayoutConversions pass. In some cases during rewriteSlice process, reduce operation with multiple outputs rewrites only one output layout, which breaks assumption that both outputs should have same layout. This change is a minimal part of triton-lang#2331 change and small lit test for regression testing. * fix combine test * Fix issue with incorrect inference layout of make_range output result
jataylo
pushed a commit
to ROCm/triton
that referenced
this pull request
Nov 3, 2023
* [RemoveLayoutConversions] Fix reduce failed infer type error This PR fixes layout propagation algorithm in RemoveLayoutConversions pass. In some cases during rewriteSlice process, reduce operation with multiple outputs rewrites only one output layout, which breaks assumption that both outputs should have same layout. This change is a minimal part of triton-lang#2331 change and small lit test for regression testing. * fix combine test * Fix issue with incorrect inference layout of make_range output result
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
…iton-lang#2331) Improve patterns that sync broadcast to reduce the arithmetic density and also hoist convert on top of expand_dims to do less work. This address comments in triton-lang#2274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve patterns that sync broadcast to reduce the arithmetic density and also hoist convert on top of expand_dims to do less work.
This address comments in #2274