Skip to content

[BACKEND] Unify slow/fast reduce codegen#2220

Merged
ptillet merged 21 commits into
mainfrom
zahi/unify-reduce
Sep 12, 2023
Merged

[BACKEND] Unify slow/fast reduce codegen#2220
ptillet merged 21 commits into
mainfrom
zahi/unify-reduce

Conversation

@zahimoud
Copy link
Copy Markdown
Contributor

@zahimoud zahimoud commented Aug 31, 2023

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 31, 2023

⚠️ This PR does not produce bitwise identical kernels as the branch it's merged against. Please check artifacts for details. Download the output file here.

peterbell10
peterbell10 reviewed Aug 31, 2023
View reviewed changes
Comment thread lib/Analysis/Utility.cpp Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 31, 2023

⚠️ This PR does not produce bitwise identical kernels as the branch it's merged against. Please check artifacts for details. Download the output file here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 31, 2023

⚠️ This PR does not produce bitwise identical kernels as the branch it's merged against. Please check artifacts for details. Download the output file here.

@zahimoud zahimoud changed the title [BACKEND] Attempt to simplify fast reduce [BACKEND] Unify slow/fast reduce codegen Aug 31, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 31, 2023

⚠️ This PR does not produce bitwise identical kernels as the branch it's merged against. Please check artifacts for details. Download the output file here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 6, 2023

⚠️ This PR does not produce bitwise identical kernels as the branch it's merged against. Please check artifacts for details. Download the output file here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 8, 2023

⚠️ This PR does not produce bitwise identical kernels as the branch it's merged against. Please check artifacts for details. Download the output file here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 8, 2023

⚠️ This PR does not produce bitwise identical kernels as the branch it's merged against. Please check artifacts for details. Download the output file here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 12, 2023

⚠️ This PR does not produce bitwise identical kernels as the branch it's merged against. Please check artifacts for details. Download the output file here.

@zahimoud zahimoud marked this pull request as ready for review September 12, 2023 00:17
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 12, 2023

⚠️ This PR does not produce bitwise identical kernels as the branch it's merged against. Please check artifacts for details. Download the output file here.

@Jokeren
Copy link
Copy Markdown
Contributor

Jokeren commented Sep 12, 2023

This is very nice, thanks!

@ptillet ptillet merged commit a47f1f5 into main Sep 12, 2023
@ptillet ptillet deleted the zahi/unify-reduce branch September 12, 2023 15:46
Stonepia added a commit to intel/intel-xpu-backend-for-triton that referenced this pull request Sep 14, 2023
@Stonepia
Unify slow/fast reduce codegen
68024a4 
This aligns with the upstream changes in triton-lang/triton#2220
@Stonepia Stonepia mentioned this pull request Sep 14, 2023
Merged
Stonepia added a commit to intel/intel-xpu-backend-for-triton that referenced this pull request Sep 20, 2023
@Stonepia
Rebase the backend to align with upstream (#96)
7fa8da9 
* Unify slow/fast reduce codegen
This aligns with the upstream changes in triton-lang/triton#2220

* Rebase from upstream #2287

triton-lang/triton#2287

* Port from (#2292)
triton-lang/triton#2292

* Fix the JIT error when the signature is empty

* Fix the issue where threadsPerWarp Logic changed

* Delete unused code

* Update expected failure case

* Update Triton Commit
alexander-zinoviev pushed a commit to alexander-zinoviev/triton that referenced this pull request Sep 21, 2023
@zahimoud @alexander-zinoviev
[BACKEND] Unify slow/fast reduce codegen (triton-lang#2220)
ebd554b
pingzhuu pushed a commit to siliconflow/triton that referenced this pull request Apr 2, 2024
@zahimoud
[BACKEND] Unify slow/fast reduce codegen (triton-lang#2220)
2234379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterbell10 peterbell10 peterbell10 left review comments

@ptillet ptillet ptillet approved these changes

@Jokeren Jokeren Awaiting requested review from Jokeren Jokeren is a code owner

@ThomasRaoux ThomasRaoux Awaiting requested review from ThomasRaoux

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zahimoud @Jokeren @ptillet @peterbell10