fix the Shared layout in OptimizeDotOperands pass to generate correct swizzling code#2180
Merged
ptillet merged 2 commits intotriton-lang:mainfrom Sep 13, 2023
Merged
Conversation
Contributor
Author
|
converting to draft, found some issue in some tests |
… swizzling code Also some addtional fix in Pipeline pass This fix bug triton-lang#1937
BinFan
force-pushed
the
binf/transp-bug-1937
branch
from
2b5f369 to
020907b
Compare
Contributor
Author
|
added some additional fix, remove draft status |
Collaborator
|
This looks good to me! Sorry for the delay reviewing this |
ptillet
approved these changes
Sep 13, 2023
alexander-zinoviev
pushed a commit
to alexander-zinoviev/triton
that referenced
this pull request
Sep 21, 2023
… correct swizzling code (triton-lang#2180) fix bug triton-lang#1937 Co-authored-by: Philippe Tillet <phil@openai.com>
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
… correct swizzling code (triton-lang#2180) fix bug triton-lang#1937 Co-authored-by: Philippe Tillet <phil@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix bug #1937