Skip to content

[FRONTEND] Emit warning if the result of tl.advance is unused #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptillet merged 1 commit into from
Aug 23, 2023
Merged

[FRONTEND] Emit warning if the result of tl.advance is unused #2155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions python/src/triton.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
#include <fstream>
#include <optional>
#include <pybind11/buffer_info.h>
#include <pybind11/embed.h>
#include <pybind11/functional.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
Expand Down Expand Up @@ -172,6 +173,30 @@ class TritonOpBuilder {
bool lineInfoEnabled = !triton::tools::getBoolEnv("TRITON_DISABLE_LINE_INFO");
};

static std::string locationToString(mlir::Location loc) {
std::string str;
llvm::raw_string_ostream os(str);
loc.print(os);
os.flush(); // Make sure all the content is dumped into the 'str' string
return str;
}

static void outputWarning(mlir::Location loc, const std::string &msg) {
std::string locStr = locationToString(loc);

py::exec(
R"(
import warnings

def custom_showwarning(message, category, filename, lineno, file=None, line=None):
print(f"UserWarning: {message}")

warnings.showwarning = custom_showwarning
warnings.warn(f"{loc}: {msg}")
)",
py::globals(), py::dict(py::arg("loc") = locStr, py::arg("msg") = msg));
}

/*****************************************************************************/
/* Python bindings for triton::ir */
/*****************************************************************************/
Expand Down Expand Up @@ -596,6 +621,17 @@ void init_triton_ir(py::module &&m) {
newBlock->erase();
}
});
// 2. Check if the result of tl.advance is used
self.walk([&](mlir::Operation *op) {
if (mlir::isa<mlir::triton::AdvanceOp>(op) &&
op->getResult(0).use_empty())
outputWarning(op->getLoc(), "The result of tl.advance is not "
"being used. Note that tl.advance "
"does not have any side effects. "
"To move the block pointer, you "
"need to assign the result of "
"tl.advance to a variable.");
});
})
.def_property_readonly("type", &mlir::triton::FuncOp::getFunctionType)
.def("reset_type", &mlir::triton::FuncOp::setType);
Expand Down