Skip to content

[DOCS] add missing docs#2154

Merged
ptillet merged 3 commits intotriton-lang:mainfrom
khushi-411:add_docs
Sep 13, 2023
Merged

[DOCS] add missing docs#2154
ptillet merged 3 commits intotriton-lang:mainfrom
khushi-411:add_docs

Conversation

@khushi-411
Copy link
Copy Markdown
Contributor

Hi,
While reading through the documentation, I noticed some missing information, like below:
image
The same is true for fdiv and umulhi. This PR addresses those gaps.

I'm looking forward to hearing from the team. :-)
Thank you!

@khushi-411 khushi-411 requested a review from ptillet as a code owner August 22, 2023 19:52
@zhanglx13
Copy link
Copy Markdown
Collaborator

Is there an assumption that trans operates data in shared memory?

@Jokeren
Copy link
Copy Markdown
Contributor

Jokeren commented Aug 23, 2023

Is there an assumption that trans operates data in shared memory?

Yes, that's why it caused several bugs.

@Jokeren
Copy link
Copy Markdown
Contributor

Jokeren commented Aug 23, 2023

both tl.trans and tl.reshape (tl.view) are unstable at the current stage because they adjust the tensor layout without actually adjusting the position of elements.

@zhanglx13
Copy link
Copy Markdown
Collaborator

Yes, that's why it caused several bugs.

Is it because not "everyone" (the user and different parts of the lowering passes) knows that trans operates in shared memory?
At python level, triton exposes the concept of global memory, so load is needed. But shared memory concept is hidden.

@Jokeren
Copy link
Copy Markdown
Contributor

Jokeren commented Aug 23, 2023

Is it because not "everyone" (the user and different parts of the lowering passes) knows that trans operates in shared memory?

The users shouldn't be aware of that. And I think it's just yet another TODO item that needs to be improved.

@khushi-411
Copy link
Copy Markdown
Contributor Author

khushi-411 commented Aug 28, 2023

Hi, @Jokeren, @zhanglx13!
Gentle ping! Could you please take a look at the PR whenever you are free? Please let me know if there's anything I need to add more. Thanks :-)

@ptillet ptillet enabled auto-merge (squash) September 13, 2023 18:53
@ptillet ptillet merged commit c61d772 into triton-lang:main Sep 13, 2023
@khushi-411 khushi-411 deleted the add_docs branch September 13, 2023 20:52
alexander-zinoviev pushed a commit to alexander-zinoviev/triton that referenced this pull request Sep 21, 2023
pingzhuu pushed a commit to siliconflow/triton that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants