Skip to content

NFC: build fixes #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptillet merged 3 commits into from
May 16, 2023
Merged

NFC: build fixes #1676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c22b1a
Remove unused variable.
chsigg May 3, 2023
7e16633
Fix reorder-ctor warning.
chsigg May 4, 2023
1eca1f1
Remove unused variables.
chsigg May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/Analysis/AxisInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,6 @@ unsigned ModuleAxisInfoAnalysis::getPtrContiguity(Value ptr) {
if (!tensorTy)
return 1;
auto layout = tensorTy.getEncoding();
auto shape = tensorTy.getShape();

// Here order should be ordered by contiguous first, so the first element
// should have the largest contiguous.
Expand Down
6 changes: 3 additions & 3 deletions lib/Conversion/TritonGPUToLLVM/TritonGPUToLLVMPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ struct ReturnOpConversion : public ConvertOpToLLVMPattern<triton::ReturnOp> {
struct FuncOpConversion : public FuncOpConversionBase {
FuncOpConversion(LLVMTypeConverter &converter, int numWarps,
ModuleAllocation &allocation, PatternBenefit benefit)
: FuncOpConversionBase(converter, benefit), allocation(allocation),
numWarps(numWarps) {}
: FuncOpConversionBase(converter, benefit), numWarps(numWarps),
allocation(allocation) {}

triton::FuncOp amendFuncOp(triton::FuncOp funcOp,
ConversionPatternRewriter &rewriter) const {
Expand Down Expand Up @@ -185,7 +185,7 @@ struct CallOpConversion : public ConvertOpToLLVMPattern<triton::CallOp> {
CallOpConversion(LLVMTypeConverter &converter, int numWarps,
ModuleAllocation &allocation, PatternBenefit benefit)
: ConvertOpToLLVMPattern<triton::CallOp>(converter, benefit),
allocation(allocation), numWarps(numWarps) {}
numWarps(numWarps), allocation(allocation) {}

LogicalResult
matchAndRewrite(triton::CallOp callOp,
Expand Down
5 changes: 1 addition & 4 deletions lib/Conversion/TritonToTritonGPU/TritonToTritonGPUPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,6 @@ class TritonCallOpPattern : public OpConversionPattern<triton::CallOp> {
LogicalResult
matchAndRewrite(triton::CallOp op, OpAdaptor adaptor,
ConversionPatternRewriter &rewriter) const override {
auto converter = getTypeConverter();
auto newOp = rewriter.replaceOpWithNewOp<triton::CallOp>(
op, op.getCallee(), op.getResultTypes(), adaptor.getOperands());
addNamedAttrs(newOp, adaptor.getAttributes());
Expand All @@ -571,9 +570,7 @@ class TritonReturnOpPattern : public OpConversionPattern<ReturnOp> {
LogicalResult
matchAndRewrite(ReturnOp op, ReturnOp::Adaptor adaptor,
ConversionPatternRewriter &rewriter) const override {
auto converter = getTypeConverter();
auto newOp =
rewriter.replaceOpWithNewOp<ReturnOp>(op, adaptor.getOperands());
rewriter.replaceOpWithNewOp<ReturnOp>(op, adaptor.getOperands());
return success();
}
};
Expand Down