Skip to content

[BACKEND] fix typo in Membar class about WAR description and refine some code #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptillet merged 2 commits into from
May 6, 2023
Merged

[BACKEND] fix typo in Membar class about WAR description and refine some code #1629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51497bf
[BACKEND] fix typo in Membar class about WAR description and refine some
lipracer May 6, 2023
b990f74
Merge branch 'main' into main
ptillet May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions include/triton/Analysis/Allocation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,6 @@ class ModuleAllocation : public CallGraph<Allocation> {
FuncOffsetMapT sharedMemoryValue;
};

template <typename T> Interval(T, T) -> Interval<T>;

} // namespace mlir

#endif // TRITON_ANALYSIS_ALLOCATION_H
2 changes: 1 addition & 1 deletion include/triton/Analysis/Membar.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class MembarAnalysis {
/// in the following circumstances:
/// - RAW: If a shared memory write is followed by a shared memory read, and
/// their addresses are intersected, a barrier is inserted.
/// - WAR: If a shared memory read is followed by a shared memory read, and
/// - WAR: If a shared memory read is followed by a shared memory write, and
/// their addresses are intersected, a barrier is inserted.
/// The following circumstances do not require a barrier:
/// - WAW: not possible because overlapped memory allocation is not allowed.
Expand Down
5 changes: 2 additions & 3 deletions lib/Analysis/Membar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,8 @@ void MembarAnalysis::visitTerminator(Operation *op,
SmallVector<Block *> &successors) {
if (auto branchInterface = dyn_cast<BranchOpInterface>(op)) {
Block *parentBlock = branchInterface->getBlock();
for (Block *successor : parentBlock->getSuccessors()) {
successors.push_back(successor);
}
successors.append(std::begin(parentBlock->getSuccessors()),
std::end(parentBlock->getSuccessors()));
return;
}
// Otherwise, it could be a return op
Expand Down