[FRONTEND] Add descriptive messages to bare asserts#10405
Merged
Conversation
Improve error diagnostics for user-facing assert statements in semantic.py and core.py by adding "expected X, got Y" messages. This makes it easier to diagnose issues like mismatched accumulator dtype in tl.dot (ref triton-lang#10341).
lezcano
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve error diagnostics for user-facing
assertstatements insemantic.pyandcore.pyby adding descriptive messages followingthe "expected X, got Y" pattern.
As requested by @lezcano in #10341 — previously, users hitting these
asserts (e.g., mismatched accumulator dtype in
tl.dot) would get anempty
AssertionErrorwith no guidance on what went wrong.Changes
semantic.py: 17 bare asserts → descriptive messagescore.py: 5 bare asserts → descriptive messagesassert shape == X and dtype == Yinto two separateasserts for clearer diagnostics