Fix gluon attention example for fp8#10399
Merged
Merged
Conversation
Mogball
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, running
python python/examples/gluon/01-attention-forward.pyfails withThis happens when the benchmark is run with fp8.
pytest python/examples/gluon/01-attention-forward.pydoesn't fail simply because it doesn't test on fp8.The regression is from #10243 but the problematic code hardcoding a fixed column count like
config.BLOCK_N // 2has been there for a long time. Previously it only worked due to the loose convention on reinterpret.