Skip to content

[PROTON] Reduce msgpack serialization overhead-5#10397

Merged
Jokeren merged 8 commits into
mainfrom
keren/proton-fast-file-write-fixed-str
May 29, 2026
Merged

[PROTON] Reduce msgpack serialization overhead-5#10397
Jokeren merged 8 commits into
mainfrom
keren/proton-fast-file-write-fixed-str

Conversation

@Jokeren
Copy link
Copy Markdown
Contributor

@Jokeren Jokeren commented May 27, 2026

Use more fixed strings

@Jokeren Jokeren requested review from CRobeck and fywkevin as code owners May 27, 2026 17:50
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e34f965a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread third_party/proton/csrc/lib/Utility/MsgPackWriter.cpp Outdated
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-fixed-str branch from 9e34f96 to c589232 Compare May 27, 2026 18:20
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-leaves branch 2 times, most recently from 750366b to 82b7a63 Compare May 28, 2026 17:54
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-fixed-str branch 2 times, most recently from 34da6a8 to cad5171 Compare May 28, 2026 18:24
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-leaves branch from 82b7a63 to 654545f Compare May 28, 2026 18:24
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-leaves branch from 654545f to 9bbebfd Compare May 29, 2026 02:14
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-fixed-str branch 2 times, most recently from 1ae9c72 to 5480d9d Compare May 29, 2026 12:03
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-leaves branch from 9bbebfd to 46e93a1 Compare May 29, 2026 12:03
Base automatically changed from keren/proton-fast-file-write-leaves to main May 29, 2026 13:13
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-fixed-str branch from 5480d9d to bd231fa Compare May 29, 2026 13:21
@Jokeren Jokeren merged commit 9e0f8bf into main May 29, 2026
10 checks passed
@Jokeren Jokeren deleted the keren/proton-fast-file-write-fixed-str branch May 29, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants