[KERNELS] Enhance matmul_torch to support K-ragged activations with appropriate assertions and output scaling#10364
Closed
Jokeren wants to merge 1 commit into
Closed
[KERNELS] Enhance matmul_torch to support K-ragged activations with appropriate assertions and output scaling#10364Jokeren wants to merge 1 commit into
Jokeren wants to merge 1 commit into
Conversation
… assertions and output scaling
Contributor
Author
|
Hi @roman-openai can you take a look? I'm not very sure why it's broken after recent updates |
ThomasRaoux
reviewed
May 25, 2026
Comment on lines
+801
to
+805
| if ( | ||
| a_ragged_metadata is not None | ||
| and b_ragged_metadata is None | ||
| and a.shape[-1] != b.shape[-2] | ||
| ): |
Collaborator
There was a problem hiding this comment.
why do we need a new special case?
Contributor
Author
|
Close the PR as this is not the right fix |
Collaborator
|
#10382 - I think this should fix it, lmk if it breaks again! |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.