Skip to content

[AMD] Skip triton-to-gluon translator tests on RDNA3/RDNA4#10304

Merged
antiagainst merged 1 commit into
triton-lang:mainfrom
saeid-rostami:skip-triton-gluon-rdna
May 13, 2026
Merged

[AMD] Skip triton-to-gluon translator tests on RDNA3/RDNA4#10304
antiagainst merged 1 commit into
triton-lang:mainfrom
saeid-rostami:skip-triton-gluon-rdna

Conversation

@saeid-rostami
Copy link
Copy Markdown
Contributor

python/test/unit/tools/test_triton_to_gluon.py fails on AMD RDNA3 (gfx11xx)
and RDNA4 (gfx120x) hardware because TranslatorTarget only enumerates the
gfx targets the translator currently supports. Every test in the file errors at setup with:

ValueError: 'gfx1201' is not a valid TranslatorTarget

(observed with 9 failures on a gfx1201/gfx1100 box).

This PR adds a module-level pytestmark that skips the file when
is_hip_rdna() is true, so CI / local runs on RDNA hardware are clean.

New contributor declaration

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because I fixed a test.
  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

@antiagainst antiagainst marked this pull request as ready for review May 13, 2026 18:32
@antiagainst antiagainst requested a review from ptillet as a code owner May 13, 2026 18:32
@antiagainst antiagainst enabled auto-merge (squash) May 13, 2026 19:19
@antiagainst antiagainst disabled auto-merge May 13, 2026 19:35
@antiagainst antiagainst merged commit 06788ae into triton-lang:main May 13, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants