[GLUON] Support broadcasting of shared scatter operations and unify operand checks#10293
Merged
Conversation
…roadcasting details
…n into keren/broadcast-atomic
… parameters and improve clarity
…nd adding whitespace in shared memory classes
…pected results and clarify xchg behavior with broadcasting
Contributor
Author
|
Hi @peterbell10 can you please take a look? |
peterbell10
reviewed
May 13, 2026
Contributor
peterbell10
left a comment
peterbell10
left a comment
There was a problem hiding this comment.
lgtm, other than a small nit
Comment on lines
+307
to
+308
| if not isinstance(mask.type, ttgl.distributed_type): | ||
| mask = self.splat(mask, values.shape, values.type.layout) |
Contributor
There was a problem hiding this comment.
NIT: This should be handled by broadcast_tensors already
Contributor
Author
There was a problem hiding this comment.
I removed shape/layout checks as well since it's already handled by broadcast_tensors I suppose?
Contributor
Author
There was a problem hiding this comment.
Yeah, as gluon's broadcast_impl_value already checks layout compatibility
peterbell10
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.