Skip to content

Python typing followup to #10048#10120

Merged
peterbell10 merged 2 commits into
triton-lang:mainfrom
leijurv:typing-followup
Apr 29, 2026
Merged

Python typing followup to #10048#10120
peterbell10 merged 2 commits into
triton-lang:mainfrom
leijurv:typing-followup

Conversation

@leijurv
Copy link
Copy Markdown
Contributor

@leijurv leijurv commented Apr 23, 2026

@jeffniu-openai said PR plz here: #10048 (comment)

Making this PR on behalf of @saagarjha (he is waiting on #8913)

New contributor declaration

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • This PR does not need a test because it's just typing.
  • Select one of the following.

    • I have not added any lit tests.

@leijurv leijurv requested a review from ptillet as a code owner April 23, 2026 19:47
Co-authored-by: Saagar Jha <saagar@saagarjha.com>
Co-authored-by: Claude <noreply@anthropic.com>
@lezcano lezcano requested a review from Mogball April 24, 2026 08:09
@saagarjha
Copy link
Copy Markdown
Contributor

Worth noting that I used instance: Any because it seemed to solve a problem where static methods were being deduced as needing a self parameter. I'm not entirely sure this is the right way to do it but it does make the type checker happy for my code at least.

@peterbell10 peterbell10 merged commit 3cb4aec into triton-lang:main Apr 29, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants